feat: mount pod patch with nodeSelector#1512
Merged
zxh326 merged 13 commits intojuicedata:masterfrom Mar 30, 2026
Merged
Conversation
Contributor
Author
|
@zxh326 hi，有时间审核一下PR吗？ |
Member
|
现在这个感觉没有考虑到 如何处理平滑升级？比如我们在 dashboard 中也会尝试算出 mountpod 配置，来计算配置是否更新，但 dashboard 不是固定在某一个 node 上的 |
Awadabang
force-pushed
the
feat/node-selector-patch
branch
from
57fa2f9 to
215a1f5
Compare
Contributor
Author
已更新 |
Collaborator
|
@zxh326 PTAL |
Awadabang
force-pushed
the
feat/node-selector-patch
branch
from
5b04c43 to
273d656
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Awadabang
force-pushed
the
feat/node-selector-patch
branch
from
273d656 to
31b08ff
Compare
CaitinChen
reviewed
Mar 25, 2026
zxh326
requested changes
Mar 27, 2026
Member
zxh326
left a comment
zxh326
left a comment
There was a problem hiding this comment.
我感觉现在有点复杂。
当前实现把 node labels 放到了 config 包级全局状态里，再让 patch 匹配回退依赖这份隐式上下文。这样一来，匹配结果不再只由当前传入的参数决定，还会取决于运行时这份全局状态是否已经初始化、是否和实际 node 保持一致。
我觉得更稳妥的做法是把 node 作为显式上下文传进 patch / diff 的计算路径，并在 controller、dashboard、CSI node 这些需要重算 setting 的地方统一调用。这样匹配逻辑只依赖明确输入，行为也能保持一致。
Member
|
我来接手这个 PR ，做一些修改 Thanks @Awadabang |
Contributor
Author
好的，多谢 |
Signed-off-by: Xuhui zhang <xuhui@juicedata.io>
Signed-off-by: Xuhui zhang <xuhui@juicedata.io>
Signed-off-by: Xuhui zhang <xuhui@juicedata.io>
zxh326
approved these changes
Mar 30, 2026
zwwhdls
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
不同资源的node，对mount pod的资源、缓存设置等等可能会有特殊的要求
增加了NodeSelector字段来针对节点特制mount pod option