Fix cachegroup dryrun affinity and warmup command #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issues with cachegroup dryrun affinity and warmup command handling. The changes address two main problems: incorrect image parameter usage in warmup commands and the need for conditional node affinity binding in cache group worker pods.
Changes:
- Fixed warmup command to use the correct image parameter for checking warmup stats support
- Added
dryrunparameter toNewCacheGroupWorkerto control node-specific affinity binding - Updated all callers of
NewCacheGroupWorkerto specify the dryrun behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/builder/job.go | Modified getWarmUpCommand to accept and use the correct image parameter, fixing a bug where WarmupSupportStats might check the wrong image |
| pkg/builder/cache_group_pod.go | Added dryrun parameter to NewCacheGroupWorker to conditionally add node-specific affinity based on use case |
| internal/controller/cachegroup_controller.go | Updated all three callers of NewCacheGroupWorker with appropriate dryrun values for their respective contexts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
这个什么时候发布0.7.6呢? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #99 #100