chore: optimize sync stats update #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
zxh326
changed the title
There was a problem hiding this comment.
Pull request overview
This PR optimizes the sync reconciler by improving error handling and adding metrics validation to prevent errors when required metrics are unavailable.
- Refactored error handling in the
Reconcilemethod to explicitly check for NotFound errors - Added error logging and validation in
calculateSyncStatsto handle missing metrics gracefully
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zwwhdls
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.