Clone optimizations #6541
Draft
Clone optimizations #6541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eakman-datadog
force-pushed
the
clone-optimizations
branch
from
4aa9dab to
8ff8aaf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6541 +/- ##
==========================================
- Coverage 51.54% 44.99% -6.55%
==========================================
Files 43 102 +59
Lines 24029 20958 -3071
==========================================
- Hits 12385 9430 -2955
- Misses 10006 10651 +645
+ Partials 1638 877 -761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| var dstIno Ino | ||
| var _a Attr | ||
| if eno = m.en.doLookup(ctx, parent, name, &dstIno, &_a); eno == 0 { |
Contributor
There was a problem hiding this comment.
Repeats the newly added 'lookup' logic above
| `, m.tablePrefix, m.tablePrefix, m.tablePrefix) | ||
|
|
||
| // Use the engine's SQL API to get raw rows instead of xorm.Rows | ||
| sqlResult, err := s.QueryString(query, rootIno) |
Contributor
There was a problem hiding this comment.
QueryString will load all the results into memory at once. For very large directory trees, this may cause memory pressure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.