cmd/sync: change tmp file name #6665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom internal files
jiefenghuang
reviewed
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a .jfs. prefix to temporary file names created during sync operations to better distinguish JuiceFS internal temporary files from business files being synced. The prefix is added to two storage backends used during sync operations.
Changes:
- Updated temporary file naming in the file storage backend from
.{name}.tmp{random}to.jfs.{name}.tmp{random} - Updated temporary file naming in the JuiceFS storage backend from
.{name}.tmp.{random}to.jfs.{name}.tmp.{random}
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/object/file.go | Adds .jfs. prefix to temporary files created by the file storage backend during Put operations |
| cmd/object.go | Adds .jfs. prefix to temporary files created by the JuiceFS storage backend during Put operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rom internal files
zhijian-pro
force-pushed
the
sync-prefix
branch
from
7340b4f to
0beff42
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiefenghuang
approved these changes
Feb 5, 2026
jiefenghuang
changed the title
zhijian-pro
added a commit
that referenced
this pull request
Feb 5, 2026
(cherry picked from commit 2dd3f31) # Conflicts: # pkg/object/cifs.go
jiefenghuang
pushed a commit
that referenced
this pull request
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rom internal files