Skip to content

Issue 1467 Fix #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Issue 1467 Fix #1523

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
477eace
1467 Fix
UntidyPhishBass Jul 6, 2025
89cbb02
Merge branch 'julep-ai:dev' into dev
UntidyPhishBass Jul 6, 2025
7dc764a
Update litellm.py
UntidyPhishBass Jul 6, 2025
53f02c5
Merge branch 'dev' of https://github.com/UntidyPhishBass/julep into dev
UntidyPhishBass Jul 6, 2025
e961a38
Update litellm.py
UntidyPhishBass Jul 6, 2025
8bd93ae
Update litellm.py
UntidyPhishBass Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/agents-api/agents_api/clients/litellm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ async def acompletion(
)

custom_api_key = secret and secret.value
model = f"openai/{model}" # This is needed for litellm
model = f"openai/{model.removeprefix('openai/')}" # This is needed for litellm
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting the model normalization (using removeprefix) into a helper function to avoid duplication and ensure consistent behavior across functions. Also, ensure that your minimum Python version supports str.removeprefix (Python 3.9+).


supported_params: list[str] = (
get_supported_openai_params(model) or []
Expand Down Expand Up @@ -136,9 +136,8 @@ async def aembedding(
custom_api_key: str | None = None,
**settings,
) -> list[list[float]]:
if not custom_api_key:
model = f"openai/{model}" # This is needed for litellm

model = f"openai/{model.removeprefix('openai/')}" # This is needed for litellm
input = (
[inputs]
if isinstance(inputs, str)
Expand Down