Breaking: Change min to return the latest patch (but still the minimum major/minor); also, add min-minor and min-patch#375
Draft
DilumAluthge wants to merge 8 commits intomasterfrom
Draft
Breaking: Change min to return the latest patch (but still the minimum major/minor); also, add min-minor and min-patch#375DilumAluthge wants to merge 8 commits intomasterfrom
min to return the latest patch (but still the minimum major/minor); also, add min-minor and min-patch#375DilumAluthge wants to merge 8 commits intomasterfrom
Conversation
The major/minor will be the minimum, but the patch will be the latest. E.g. `julia = "1.10"` would lead to e.g. 1.10.10 (not 1.10.0).
Member
Author
|
I might post about this on Discourse, to get feedback. |
|
Please link the topic here if you do, though I think this is fairly non-controversial, and more of a bugfix than a breaking change. I am not sure there is a use case for getting 1.x.0 instead of the latest 1.x.y, since the difference should just be bugfixes. |
DilumAluthge
changed the title
min to return the latest patchmin to return the latest patch (but still the minimum major/minor)
DilumAluthge
changed the title
min to return the latest patch (but still the minimum major/minor)min to return the latest patch (but still the minimum major/minor); also, add min-minor and min-patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The major/minor will be the minimum, but the patch will be the latest. E.g.
julia = "1.10"would lead to e.g. 1.10.11 (not 1.10.0).Fixes #372
Before this PR:
min=> 1.10.0After this PR:
min-patch=> 1.10.0 (minimum major/minor/patch)min-minor=> 1.10.11 (minimum major/minor, latest patch)min=> equivalent tomin-minor(1.10.11)