libjulius: Fix incompatible types in POSIX threads configure checks#195
Open
fweimer-rh wants to merge 1 commit intojulius-speech:masterfrom
Open
libjulius: Fix incompatible types in POSIX threads configure checks#195fweimer-rh wants to merge 1 commit intojulius-speech:masterfrom
fweimer-rh wants to merge 1 commit intojulius-speech:masterfrom
Conversation
NULL is not necessarily a valid pthread_t value. Compilers increasingly enforce C type safety, and these configure checks may fail incorrectly with such compilers. POSIX guarantees that pthread_self() returns a valid pthread_t value, so use that instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NULL is not necessarily a valid
pthread_tvalue. Compilers increasingly enforce C type safety, and these configure checks may fail incorrectly with such compilers. POSIX guarantees thatpthread_self()returns a validpthread_tvalue, so use that instead.Related to: