Skip to content

enh: add harp config #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyteinsky wants to merge 6 commits into
base: master
Choose a base branch
from
Open

enh: add harp config #382

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bee1ce6
enh: add harp config
kyteinsky Feb 12, 2025
8ed76a6
env var changes
kyteinsky Feb 12, 2025
6ba6eb3
vhost change to location + env fixes
kyteinsky Feb 25, 2025
e1233ca
updates
kyteinsky Feb 27, 2025
b056aad
add env HP_SESSION_LIFETIME
kyteinsky Feb 27, 2025
c205895
change name to appapi-harp
kyteinsky Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions data/nginx/vhost.d/nextcloud.local_location
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
location /exapps/ {
set $harp_addr nextcloud-appapi-harp:8780;
proxy_pass http://$harp_addr;
}

Empty file added data/ssl/harp/.gitkeep
View file
Open in desktop
Empty file.
20 changes: 20 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,6 +1106,26 @@ services:
- EX_APPS_NET=${EX_APPS_NET:-ipv4@localhost}
- EX_APPS_COUNT=${EX_APPS_COUNT:-50}

appapi-harp:
image: ghcr.io/nextcloud/nextcloud-appapi-harp:latest
container_name: nextcloud-appapi-harp
network_mode: ${HP_NETWORK_MODE:-master_default}
Copy link
Owner

@juliusknorr juliusknorr Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about those parts, why do we need to set the network mode here actually?

Copy link
Contributor Author

@kyteinsky kyteinsky Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One can work with different kinds of configurations like host or any other network, for testing.

volumes:
- /var/run/docker.sock:/var/run/docker.sock
- ${CERT_PATH:-./data/ssl/harp/}:/certs
ports:
- "8780:8780"
- "8781:8781"
- "8782:8782"
environment:
- HP_SHARED_KEY=${HP_SHARED_KEY:-some_very_secure_password}
- NC_INSTANCE_URL=${HP_NC_INSTANCE_URL:-http://nextcloud.local}
- HP_FRP_DISABLE_TLS=${HP_FRP_DISABLE_TLS:-false}
- HP_EXAPPS_ADDRESS=${HP_EXAPPS_ADDRESS:-0.0.0.0:8780}
- HP_EXAPPS_HTTPS_ADDRESS=${HP_EXAPPS_HTTPS_ADDRESS:-0.0.0.0:8781}
- HP_FRP_ADDRESS=${HP_FRP_ADDRESS:-0.0.0.0:8782}
- HP_LOG_LEVEL=${HP_LOG_LEVEL:-info}
- HP_VERBOSE_START=${HP_VERBOSE_START:-1}

volumes:
data:
Expand Down
Loading