Check constraint and objective is DCP when adding #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 98.24% 98.25%
=======================================
Files 87 87
Lines 5192 5202 +10
=======================================
+ Hits 5101 5111 +10
Misses 91 91 ☔ View full report in Codecov by Sentry. |
blegat
approved these changes
Dec 5, 2024
Member
blegat
left a comment
blegat
left a comment
There was a problem hiding this comment.
Indeed, that's an issue, this fix seems appropriate
odow
commented
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #713
Note sure what the best approach is.