-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for SumOfSquares cone #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
==========================================
- Coverage 96.80% 96.68% -0.12%
==========================================
Files 55 56 +1
Lines 9086 9092 +6
==========================================
- Hits 8796 8791 -5
- Misses 290 301 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@chriscoey @lkapelevich This PR is now ready for your review :) |
|
@blegat could you explain what My second question is... what happens if you make LRO a weak dependency instead of a requirement? Would it be a mess? My third question is... your LRO sets are really general. So what if someone has a |
|
Each vector
No, that should be possible |
|
Aha, I didn't catch that It could be nice not to add a hard dependency, but I don't feel strongly. |
| MOI.DualExponentialCone, | ||
| MOI.LogDetConeTriangle, | ||
| MOI.RelativeEntropyCone, | ||
| _PrimalRankOnePSD{T}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the part that would get complicated if it's an extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As _PrimalRankOnePSD starts with an underscore, it can always be moved as an extension later in a non-breaking way
With this PR, when the user uses the sampling basis, e.g. with
the constraint will be transformed to
Hypatia.WSOSInterpNonnegativeConeand not all the way to PSD constraints!A few things still need to happen before this can be part of a release. To use this, one needs the development version of
StarAlgebras,MultivariateMomentsandPolyJuMPas well as