Conversation
Collaborator
Author
|
Examples don't run because of #862, but they work fine locally on 1.11. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
==========================================
- Coverage 96.75% 96.62% -0.13%
==========================================
Files 56 56
Lines 9117 9095 -22
==========================================
- Hits 8821 8788 -33
- Misses 296 307 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
|
Member
|
Examples failed? |
Collaborator
Author
|
Argh, forgot to use the new version of Hypatia when running the examples locally. Should be fixed now. |
blegat
approved these changes
Oct 22, 2025
Member
blegat
left a comment
There was a problem hiding this comment.
Nice! The drop in code coverage is just due to the fact that you removed lines that were covered so it looks good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real PSD, logdet, and rootdet cones benefit. It's my favourite kind of PR, net negative LOC.