Skip to content

use MOI.Scaled to remove custom bridges#863

Merged
araujoms merged 2 commits intomasterfrom
araujoms/scaled
Oct 22, 2025
Merged

use MOI.Scaled to remove custom bridges#863
araujoms merged 2 commits intomasterfrom
araujoms/scaled

Conversation

@araujoms
Copy link
Collaborator

Real PSD, logdet, and rootdet cones benefit. It's my favourite kind of PR, net negative LOC.

@araujoms
Copy link
Collaborator Author

Examples don't run because of #862, but they work fine locally on 1.11.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.62%. Comparing base (f80bd8e) to head (656cd90).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   96.75%   96.62%   -0.13%     
==========================================
  Files          56       56              
  Lines        9117     9095      -22     
==========================================
- Hits         8821     8788      -33     
- Misses        296      307      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow
Copy link
Member

odow commented Oct 22, 2025

Can you rebase on master? I pinned the CI workflow to fix the examples. Oh, you have write access here. I've done it.

@odow
Copy link
Member

odow commented Oct 22, 2025

Examples failed?

@araujoms
Copy link
Collaborator Author

Argh, forgot to use the new version of Hypatia when running the examples locally. Should be fixed now.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The drop in code coverage is just due to the fact that you removed lines that were covered so it looks good to merge

@araujoms araujoms merged commit ac5d3cd into master Oct 22, 2025
7 of 8 checks passed
@araujoms araujoms deleted the araujoms/scaled branch October 22, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants