very minor 0.7 fixes #1346
Merged
very minor 0.7 fixes #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1346 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 24 24
Lines 3387 3387
=======================================
Hits 3025 3025
Misses 362 362
Continue to review full report at Codecov.
|
|
@mlubin What's the status of JuliaArrays/AxisArrays.jl#84 ? Would it be easier to use AxisArrays ? Of course, it might take too much time if we want broadcasting to work on JuMPArray for JuMP-dev |
|
I'm not aware of any actual progress on JuliaArrays/AxisArrays.jl#84. However, JuliaArrays/AxisArrays.jl#131 might be useful as an example for implementing the broadcast interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stopped for the evening after getting to https://docs.julialang.org/en/latest/manual/interfaces/#man-interfaces-broadcasting-1. We have to implement this new broadcasting interface for JuMPArray.