Skip to content

Fix reshaping ::Nothing for matrix shapes#3988

Merged
odow merged 4 commits intomasterfrom
od/fix-reshape-nothing
Apr 30, 2025
Merged

Fix reshaping ::Nothing for matrix shapes#3988
odow merged 4 commits intomasterfrom
od/fix-reshape-nothing

Conversation

@odow
Copy link
Copy Markdown
Member

@odow odow commented Apr 30, 2025

Found writing #3987

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b4fc548) to head (c9e1b7a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3988   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         6081      6082    +1     
=========================================
+ Hits          6081      6082    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blegat
Copy link
Copy Markdown
Member

blegat commented Apr 30, 2025

Can't we do reshape_vector(::Nothing, ::AbstractShape) = nothing ? If this edge-case was missed, it is surely missed also by extensions that defines shapes (e.g. PolyJuMP) so defining for AbstractShape would be nice

@odow odow merged commit 27611e1 into master Apr 30, 2025
11 checks passed
@odow odow deleted the od/fix-reshape-nothing branch April 30, 2025 21:29
@odow odow mentioned this pull request Apr 30, 2025
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants