[Containers] fix sum of DenseAxisArray that doesn't support zero(T) #4097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4097 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 43 43
Lines 5907 5910 +3
=======================================
+ Hits 5897 5900 +3
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blegat
reviewed
Dec 14, 2025
|
|
||
| function test_init_issue_4096() | ||
| x = Containers.DenseAxisArray(Any[1, 2, 3], Int[1, 2, 3]) | ||
| @test sum(x) == 6 |
Member
There was a problem hiding this comment.
Can you add a test with @allocated ... == 0 to check that the dispatch is done a compile time ? It think it is still able to do this if-else at compile time
Member
Author
There was a problem hiding this comment.
Yes, but this is a bug fix. Even if it allocated we should merge
Adjust sum behavior tests based on Julia version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't dispatch on keyword types, so we need to implement a run-time dispatch.
Closes #4096