Skip to content

[FileFormats.NL] clarify comment about binary format #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 1 commit into from
Apr 10, 2025
Merged

[FileFormats.NL] clarify comment about binary format #2720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/FileFormats/NL/read.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,9 @@ end

function _parse_header(io::IO, model::_CacheModel)
# Line 1
# We don't support the binary format.
byte = read(io, UInt8)
# Detect the format. We delay setting `model.is_binary` until the end of
# this function because the header is _not_ in binary format.
is_binary = false
if byte == UInt8('b')
is_binary = true
Expand Down
Loading