Disable linearity detection for subexpression if no hessian #2738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Apr 27, 2025
odow
approved these changes
Apr 27, 2025
Member
odow
left a comment
odow
left a comment
There was a problem hiding this comment.
So this is okay. But more generally, we should consider:
- Is it worth making code changes for edge cases?
This requires Hessians to be disabled AND the model to have many subexpressions AND the linearity check to take a non-trivial amount of time.
I'd be in favor of fewer special cases, even if it meant a small decrease in performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done for
_FunctionStoragebut not here