[docs] filter varying width Time column in doctest#2748
Merged
odow merged 4 commits intojump-dev:masterfrom May 8, 2025
Merged
[docs] filter varying width Time column in doctest#2748odow merged 4 commits intojump-dev:masterfrom
odow merged 4 commits intojump-dev:masterfrom
Conversation
odow
approved these changes
May 8, 2025
Member
odow
left a comment
odow
left a comment
There was a problem hiding this comment.
Oh I got confused. The Time column shifted over because of the extra digit in the time.
odow
reviewed
May 8, 2025
odow
reviewed
May 8, 2025
odow
reviewed
May 8, 2025
odow
reviewed
May 8, 2025
Contributor
Author
|
Hmm. I am not sure we need to escape in the Markdown files actually. |
Member
|
Oh just the docstrings? |
odow
reviewed
May 8, 2025
odow
reviewed
May 8, 2025
Contributor
Author
|
I think so.. I think it's just the string literals in Julia code where we have the notion of escape sequences. This worked correctly as far as I can tell:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't explicitly verify this, but I think this should hopefully avoid the doctest failure we sometimes see (JuliaDocs/Documenter.jl#2704).