Add nospecialize to some very highly specialized methods #2830
+40
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These cut 100k method instances. Still need to benchmark properly. |
blegat
reviewed
Sep 4, 2025
| ::Type{<:AbstractBridge}, | ||
| ::Type{<:MOI.AbstractFunction}, | ||
| ::Type{<:MOI.AbstractSet}, | ||
| @nospecialize(BT::Type{<:AbstractBridge}), |
blegat
reviewed
Sep 4, 2025
| b::LazyBridgeOptimizer, | ||
| ::Type{BT}, | ||
| ) where {BT<:AbstractBridge} | ||
| @nospecialize(b::LazyBridgeOptimizer), |
There was a problem hiding this comment.
All these shouldn't affect performance, it's a must do indeed
blegat
reviewed
Sep 4, 2025
| ::Type{S}, | ||
| ) where {F<:MOI.AbstractFunction,S<:MOI.AbstractSet} | ||
| @nospecialize(model::AbstractModel), | ||
| @nospecialize(F::Type{<:MOI.AbstractFunction}), |
blegat
reviewed
Sep 4, 2025
| ::Type{<:AbstractFunction}, | ||
| ::Type{<:AbstractSet}, | ||
| @nospecialize(::ModelLike), | ||
| @nospecialize(F::Type{<:AbstractFunction}), |
There was a problem hiding this comment.
Since it's a fallback returning false, I don't believe it will affect the performance of bottleneck to looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref #2829