[docs] improve docstring of VectorNonlinearOracle#2876
Merged
Conversation
franckgaga
approved these changes
Oct 31, 2025
Contributor
franckgaga
left a comment
franckgaga
left a comment
There was a problem hiding this comment.
I did not verify the derivatives since I'm a bit lazy right now, but they seems okay XP
|
|
||
| `jacobian_structure` is not required to be sorted and it may contain duplicates, | ||
| in which case the solver will combine the corresponding non-zero values in `ret` | ||
| by adding them together. |
Contributor
There was a problem hiding this comment.
Did you meant "averaging them together" ?
"Adding them together" feels like giving [(1,1), (1,1), (1,1)] and [1.0, 1.0, 1.0] would fill the Hessian with a 3.0 instead of a 1.0 at the index 1,1.
Member
Author
There was a problem hiding this comment.
No, I mean adding them together. It would fill in 3.0 at the index 1, 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-ref this discussion https://discourse.julialang.org/t/computing-hessian-of-the-langrangian-efficiently-with-di-jl/133462/11