Skip to content

Enable vOptLib tests for KirlikSayin and TambyVanderpooten #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 1 commit into from
Jun 16, 2025
Merged

Enable vOptLib tests for KirlikSayin and TambyVanderpooten #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/algorithms/DominguezRios.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import MultiObjectiveAlgorithms as MOA
import MultiObjectiveAlgorithms: MOI

include(joinpath(dirname(@__DIR__), "problems.jl"))
include(joinpath(dirname(@__DIR__), "vOptLib.jl"))

function run_tests()
if Sys.WORD_SIZE == 32
Expand All @@ -35,6 +36,15 @@ function test_problems()
return
end

function test_vOptLib_runtests()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.DominguezRios())
MOI.set(model, MOI.Silent(), true)
# TODO(odow): it doesn't terminate
# vOptLib.run_tests(model)
Copy link
Member Author

@odow odow Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kofgokhan it looks like there's a bug in DominguezRios. It doesn't terminate on this problem (it gets into an infinite loop):

using Revise
import HiGHS
import MultiObjectiveAlgorithms as MOA
import MultiObjectiveAlgorithms: MOI

include("test/vOptLib.jl")

model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.DominguezRios())
MOI.set(model, MOI.Silent(), true)
MOI.set(model, MOI.TimeLimitSec(), 60.0)
vOptLib.test_vOptLib_2KP50_11(model)

Copy link
Contributor

@kofgokhan kofgokhan Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not replicate this on my machine. It returns 43 points. Used both HiGHS and CPLEX and I have not changed the tolerances. Did something change?

> model = MOA.Optimizer(HiGHS.Optimizer)
> MOI.get(model, MOI.RawOptimizerAttribute("primal_feasibility_tolerance"))
1.0e-7

> model = MOA.Optimizer(CPLEX.Optimizer)
> MOI.get(model, MOI.RawOptimizerAttribute("CPX_PARAM_EPRHS"))
1.0e-6

Copy link
Member Author

@odow odow Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My conclusion in #121 is that it's a presolve issue in HiGHS. If you can't replicate, then it probably means that it's machine dependent too :(

return
end

function test_infeasible()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.DominguezRios())
Expand Down
9 changes: 9 additions & 0 deletions test/algorithms/KirlikSayin.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import MultiObjectiveAlgorithms as MOA
import MultiObjectiveAlgorithms: MOI

include(joinpath(dirname(@__DIR__), "problems.jl"))
include(joinpath(dirname(@__DIR__), "vOptLib.jl"))

function run_tests()
for name in names(@__MODULE__; all = true)
Expand All @@ -32,6 +33,14 @@ function test_problems()
return
end

function test_vOptLib_runtests()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.KirlikSayin())
MOI.set(model, MOI.Silent(), true)
vOptLib.run_tests(model)
return
end

function test_infeasible()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.KirlikSayin())
Expand Down
9 changes: 9 additions & 0 deletions test/algorithms/TambyVanderpooten.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import MultiObjectiveAlgorithms as MOA
import MultiObjectiveAlgorithms: MOI

include(joinpath(dirname(@__DIR__), "problems.jl"))
include(joinpath(dirname(@__DIR__), "vOptLib.jl"))

function run_tests()
for name in names(@__MODULE__; all = true)
Expand All @@ -32,6 +33,14 @@ function test_problems()
return
end

function test_vOptLib_runtests()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.TambyVanderpooten())
MOI.set(model, MOI.Silent(), true)
vOptLib.run_tests(model)
return
end

function test_infeasible()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.TambyVanderpooten())
Expand Down
Loading