Update deploy-exporters to latest cli and add qemu exporters #138
Conversation
|
Warning Rate limit exceeded@mangelajo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 42 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
WalkthroughThe changes update Kubernetes StatefulSet manifests for Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| env: | ||
| - name: JUMPSTARTER_GRPC_INSECURE | ||
| value: "1" | ||
| # note for some reason jmp-exporter run $(cat /etc/hostname) won't find the config, neither does list | ||
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp-exporter run -c /etc/jumpstarter/exporters/$(cat /etc/hostname).yaml"] | ||
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter-config /etc/jumpstarter/exporters/$(cat /etc/hostname).yaml"] |
There was a problem hiding this comment.
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter-config /etc/jumpstarter/exporters/$(cat /etc/hostname).yaml"] | |
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter $(cat /etc/hostname)"] |
| env: | ||
| - name: JUMPSTARTER_GRPC_INSECURE | ||
| value: "1" | ||
| # note for some reason jmp-exporter run $(cat /etc/hostname) won't find the config, neither does list | ||
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp-exporter run -c /etc/jumpstarter/exporters/$(cat /etc/hostname).yaml"] | ||
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter-config /etc/jumpstarter/exporters/$(cat /etc/hostname).yaml"] |
There was a problem hiding this comment.
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter-config /etc/jumpstarter/exporters/$(cat /etc/hostname).yaml"] | |
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter $(cat /etc/hostname)"] |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (3)
hack/demoenv/exporters-statefulset.yaml (2)
19-20: Use explicit version tag rather thanlatest
As noted above, pin to version0.6for reproducibility instead oflatest.
25-25: Optional: UseHOSTNAMEenv var instead ofcat /etc/hostname
Same recommendation as in the VCAN manifest: leverage Kubernetes’HOSTNAMEvariable and the exec form to avoidsh -c.hack/demoenv/prepare_exporters.sh (1)
37-37: Portability: fix duplicatesed -i ''usage
This instance ofsed -i ''has the same portability issue. Please apply the same Linux-compatible fix as above.
🧹 Nitpick comments (1)
hack/demoenv/vcan-exporters-statefulset.yaml (1)
25-25: Optional: Simplify exporter command via Kubernetes Downward API
Instead of shelling out tocat /etc/hostname, consider using the built-inHOSTNAMEenv var and an exec form:command: - "jmp" - "run" - "--exporter-config" - "/etc/jumpstarter/exporters/${HOSTNAME}.yaml"You can ensure
HOSTNAMEis set via a Downward API fieldRef. This avoids the extra shell layer.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
hack/demoenv/exporters-statefulset.yaml(1 hunks)hack/demoenv/prepare_exporters.sh(1 hunks)hack/demoenv/vcan-exporters-statefulset.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: e2e-tests (ubuntu-24.04-arm)
- GitHub Check: e2e-tests (ubuntu-24.04)
- GitHub Check: e2e-tests-28d6b1cc3b49ab9ae176918ab9709a2e2522c97e
🔇 Additional comments (5)
hack/demoenv/prepare_exporters.sh (5)
10-11: Approve: Updated to usejmp admincommands
Thedeleteandcreatecalls have been correctly migrated frombin/jmpctltojmp admin, with appropriate flags for output and labels.
13-13: Approve: Output generated YAML for visibility
Emitting the file to stdout can aid debugging. If verbosity is a concern, consider gating it behind aDEBUGflag.
17-23: Approve: Updated mock exporter driver type paths
The driver type strings have been consistently renamed fromjumpstarter.drivers.*tojumpstarter_driver_*. This aligns with the new package layout.
35-36: Approve: Updatedjmp admincommands for CAN exporters
Same migration tojmp adminwith--outand-l device-type=canis applied correctly.
41-47: Approve: Updated CAN exporter driver type paths
Driver types for CAN exporters have been updated to the new package format (jumpstarter_driver_can.driver.Can), matching the mock exporter changes.
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
hack/demoenv/prepare_exporters.sh (1)
1-1: 🛠️ Refactor suggestionEnable strict error handling and use Bash shebang
The script currently starts with#!/bin/sh, which may not supportset -o pipefail. To catch failures early and avoid silent errors, switch to Bash and enable strict mode.-#!/bin/sh +#!/usr/bin/env bash +set -euo pipefail
♻️ Duplicate comments (1)
hack/demoenv/prepare_exporters.sh (1)
60-60: Makesed -iinvocation portable
This BSD/macOS–specific syntax will fail on Linux. Replace with the portable form:- sed -i '' '/^\s*export: {}\s*$/d' "${OUT_FILE}" + sed -i '/^\s*export: {}\s*$/d' "${OUT_FILE}"
🧹 Nitpick comments (10)
hack/demoenv/qemu-exporters-statefulset.yaml (5)
23-25: Harden container security around privileged mode
Running a privileged container introduces high risk (CKV_K8S_16). If QEMU truly requires full privileges, please add explicit documentation and consider narrowing capabilities:securityContext: privileged: true allowPrivilegeEscalation: false capabilities: drop: - ALL add: - SYS_ADMIN - MKNODOtherwise, avoid privileged mode.
🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 24-24: wrong indentation: expected 10 but found 12
(indentation)
27-32: Use binary SI units for memory
Switch from decimal ("2G","1G") to binary units ("2Gi","1Gi") for consistency with Kubernetes conventions and clearer resource semantics.
36-37: Refactor shell command to usecommand+args
Embedding complex shell logic in a single-cstring reduces readability. Consider:command: ["jmp"] args: ["run", "--exporter-config", "/etc/jumpstarter/exporters/$(HOSTNAME).yaml"] env: - name: HOSTNAME valueFrom: fieldRef: fieldPath: metadata.name
39-47: Consider mounting only the needed config file viasubPath
Mounting the entire directory exposes all configs. If each pod only needs/etc/jumpstarter/exporters/<pod-name>.yaml, use:volumeMounts: - name: exporter-configs mountPath: /etc/jumpstarter/exporters/$(HOSTNAME).yaml subPath: $(HOSTNAME).yaml
24-24: Cleanup YAML formatting
- Align
privileged:undersecurityContextto match two-space indentation.- Remove trailing spaces on blank lines (line 48).
- Correct indentation of the
volumeslist (line 50).- Ensure a newline at the end of the file (line 62).
Also applies to: 48-48, 50-50, 62-62
🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 24-24: wrong indentation: expected 10 but found 12
(indentation)
hack/demoenv/prepare_exporters.sh (5)
5-5: Quote variable expansions to handle spaces
Unquoted${OUT_DIR}can break if the path contains spaces. Wrap it in quotes:- mkdir -p ${OUT_DIR} + mkdir -p "${OUT_DIR}"
6-29: Remove or archive large commented-out blocks
Keeping large chunks of legacy code commented out adds maintenance overhead and noise. If these mock-exporter loops are no longer needed, consider removing them or moving them to a separate archival script or documentation.
30-52: Remove or archive additional commented exporter loops
Similarly, thevcan-exporterloop is fully commented out. Clean up these blocks to improve readability or extract them into version-controlled examples if they need to be retained.
54-54: Use POSIX command substitution
Backticks are harder to nest and read—prefer$(…):- for i in `seq 0 4`; do + for i in $(seq 0 4); do
68-70: Parameterize hardcoded OVMF paths for portability
The script assumes QEMU firmware files at/usr/share/AAVMF/.... It’s more robust to allow these paths to be overridden via environment variables and fall back to defaults:- OVMF_CODE.fd: /usr/share/AAVMF/OVMF_CODE.fd - OVMF_VARS.fd: /usr/share/AAVMF/OVMF_VARS.fd + OVMF_CODE.fd: ${OVMF_CODE_PATH:-/usr/share/AAVMF/OVMF_CODE.fd} + OVMF_VARS.fd: ${OVMF_VARS_PATH:-/usr/share/AAVMF/OVMF_VARS.fd}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
hack/demoenv/kustomization.yaml(2 hunks)hack/demoenv/prepare_exporters.sh(1 hunks)hack/demoenv/qemu-exporters-statefulset.yaml(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
hack/demoenv/qemu-exporters-statefulset.yaml
[MEDIUM] 1-62: Containers should not run with allowPrivilegeEscalation
(CKV_K8S_20)
[HIGH] 1-62: Container should not be privileged
(CKV_K8S_16)
[MEDIUM] 1-62: Minimize the admission of root containers
(CKV_K8S_23)
🪛 YAMLlint (1.37.1)
hack/demoenv/qemu-exporters-statefulset.yaml
[warning] 24-24: wrong indentation: expected 10 but found 12
(indentation)
[error] 48-48: trailing spaces
(trailing-spaces)
[warning] 50-50: wrong indentation: expected 6 but found 8
(indentation)
[error] 62-62: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (5)
hack/demoenv/kustomization.yaml (1)
6-6: QEMU exporter StatefulSet resource added
The new entryqemu-exporters-statefulset.yamlcorrectly extends theresourcesblock alongside the existing exporters.hack/demoenv/qemu-exporters-statefulset.yaml (3)
1-11: Selector and Pod labels are aligned correctly
Thespec.selector.matchLabels(exporter-mock: qemu) matches the Pod template labels exactly, ensuring stable network identities for each replica.🧰 Tools
🪛 Checkov (3.2.334)
[MEDIUM] 1-62: Containers should not run with allowPrivilegeEscalation
(CKV_K8S_20)
[HIGH] 1-62: Container should not be privileged
(CKV_K8S_16)
[MEDIUM] 1-62: Minimize the admission of root containers
(CKV_K8S_23)
13-16: Confirm the requirement for privileged SCC annotation
You’ve addedopenshift.io/required-scc: privilegedto grant elevated permissions on OpenShift. Please verify this is intentional for your demo environment and document it in your cluster’s security policy.
34-35: Verify insecure gRPC setting
JUMPSTARTER_GRPC_INSECURE="1"disables TLS encryption for gRPC. Confirm this is acceptable for a demo and doesn’t leak sensitive data in your test environment.hack/demoenv/prepare_exporters.sh (1)
86-90: Verify namespace consistency
The script usesNAMESPACE=${NAMESPACE:-"jumpstarter-lab"}forjmp admincommands but hardcodes-n jumpstarter-exportersfor Kubernetes operations. Please confirm whether this divergence is intentional or if a separate variable (e.g.,EXPORTERS_NAMESPACE) should be introduced for clarity and maintainability.
mangelajo
force-pushed
the
deploy-exporters-0.6
branch
from
77159e3 to
f2adcd7
Compare
mangelajo
changed the title
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
hack/demoenv/prepare_exporters.sh (1)
60-60: Ensure portablesed -iusage
Thesed -i ''invocation is macOS-specific and will fail on Linux. Update it to a portable form, for example:-sed -i '' '/^\s*export: {}\s*$/d' "${OUT_FILE}" +sed -i '/^\s*export: {}\s*$/d' "${OUT_FILE}"hack/demoenv/vcan-exporters-statefulset.yaml (1)
19-20:⚠️ Potential issuePin exporter image to specific version
Usinglatestbreaks reproducibility and diverges from the PR title. Replace with the explicitrelease-0.6tag:- image: quay.io/jumpstarter-dev/jumpstarter:latest + image: quay.io/jumpstarter-dev/jumpstarter:release-0.6
🧹 Nitpick comments (2)
hack/demoenv/prepare_exporters.sh (1)
6-28: Remove large commented-out code blocks
The script retains extensive commented loops for mock and vcan exporters. If these are no longer needed, consider removing them to improve readability and maintainability.Also applies to: 30-53
hack/demoenv/qemu-exporters-statefulset.yaml (1)
22-23: Resolve TODO for continuous release image
There's a TODO suggesting a continuous release image tag (e.g.,jumpstarter-with-qemu:latest). Please clarify which image tag should be used or automate version updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
hack/demoenv/exporters-statefulset.yaml(1 hunks)hack/demoenv/kustomization.yaml(2 hunks)hack/demoenv/prepare_exporters.sh(1 hunks)hack/demoenv/qemu-exporters-statefulset.yaml(1 hunks)hack/demoenv/vcan-exporters-statefulset.yaml(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
hack/demoenv/qemu-exporters-statefulset.yaml
[MEDIUM] 1-63: Containers should not run with allowPrivilegeEscalation
(CKV_K8S_20)
[HIGH] 1-63: Container should not be privileged
(CKV_K8S_16)
[MEDIUM] 1-63: Minimize the admission of root containers
(CKV_K8S_23)
🪛 YAMLlint (1.37.1)
hack/demoenv/qemu-exporters-statefulset.yaml
[warning] 25-25: wrong indentation: expected 10 but found 12
(indentation)
[warning] 51-51: wrong indentation: expected 6 but found 8
(indentation)
[error] 63-63: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: deploy-kind
- GitHub Check: e2e-tests (ubuntu-24.04-arm)
- GitHub Check: e2e-tests (ubuntu-24.04)
- GitHub Check: e2e-tests-28d6b1cc3b49ab9ae176918ab9709a2e2522c97e
🔇 Additional comments (4)
hack/demoenv/kustomization.yaml (1)
6-6:✅ Verification successful
Add QEMU exporter StatefulSet to resources
The newqemu-exporters-statefulset.yamlhas been correctly added underresources. Ensure this file exists and is properly configured.
🏁 Script executed:
#!/bin/bash # Verify that kustomization references the QEMU StatefulSet manifest if [[ ! -f "hack/demoenv/qemu-exporters-statefulset.yaml" ]]; then echo "❌ Missing hack/demoenv/qemu-exporters-statefulset.yaml" exit 1 fi echo "✅ QEMU StatefulSet manifest is present"Length of output: 144
QEMU exporter StatefulSet resource correctly added
Theqemu-exporters-statefulset.yamlmanifest is present inhack/demoenvand properly referenced inhack/demoenv/kustomization.yaml. No further action required.hack/demoenv/exporters-statefulset.yaml (2)
19-21: Updated exporter image tag and pull policy
The container image is pinned torelease-0.6andimagePullPolicyis set toAlways, aligning deployments with the PR objectives.
25-25: Use streamlined run command
The command is updated to invokejmp run --exporter $(cat /etc/hostname), replacing the previous longer invocation. This aligns with other exporter configurations.hack/demoenv/qemu-exporters-statefulset.yaml (1)
23-27: Address container privilege requirements
Running the container asprivileged: trueraises security flags (CKV_K8S_16). If device access must remain privileged, document this need; otherwise, scope down by dropping unnecessary capabilities or disabling privilege escalation.🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 25-25: wrong indentation: expected 10 but found 12
(indentation)
| image: quay.io/mangelajo/jumpstarter:rel6-qemu | ||
| securityContext: | ||
| privileged: true | ||
| imagePullPolicy: Always | ||
| resources: |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix YAML indentation and add newline
YAML lint reports incorrect indentation for privileged (expected 8 spaces, found 12) and a missing newline at EOF. Apply this diff:
- securityContext:
- privileged: true
+ securityContext:
+ privileged: trueEnsure a blank line at the end of the file.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| image: quay.io/mangelajo/jumpstarter:rel6-qemu | |
| securityContext: | |
| privileged: true | |
| imagePullPolicy: Always | |
| resources: | |
| image: quay.io/mangelajo/jumpstarter:rel6-qemu | |
| securityContext: | |
| privileged: true | |
| imagePullPolicy: Always | |
| resources: |
🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 25-25: wrong indentation: expected 10 but found 12
(indentation)
🤖 Prompt for AI Agents
In hack/demoenv/qemu-exporters-statefulset.yaml between lines 23 and 27, the
indentation of the privileged field under securityContext is incorrect, causing
YAML lint errors. Fix the indentation to match the expected 8 spaces and add a
newline at the end of the file to resolve formatting issues and adhere to YAML
standards.
| env: | ||
| - name: JUMPSTARTER_GRPC_INSECURE | ||
| value: "1" | ||
| # note for some reason jmp-exporter run $(cat /etc/hostname) won't find the config, neither does list | ||
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp-exporter run -c /etc/jumpstarter/exporters/$(cat /etc/hostname).yaml"] | ||
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter (cat /etc/hostname)"] |
There was a problem hiding this comment.
Correct shell command substitution
The command incorrectly uses (cat /etc/hostname) instead of shell substitution. It should be:
- command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter (cat /etc/hostname)"]
+ command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter $(cat /etc/hostname)"]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter (cat /etc/hostname)"] | |
| command: ["/bin/sh", "-c", "echo running exporter $(cat /etc/hostname); jmp run --exporter $(cat /etc/hostname)"] |
🤖 Prompt for AI Agents
In hack/demoenv/vcan-exporters-statefulset.yaml at line 25, the command uses
incorrect syntax for shell command substitution. Replace the parentheses around
(cat /etc/hostname) with dollar sign and curly braces to properly perform shell
substitution, making it $(cat /etc/hostname). This ensures the hostname is
correctly inserted into the command string.
f2adcd7 to
a776220
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
hack/demoenv/prepare_exporters.sh (1)
86-90:⚠️ Potential issueInconsistent namespace usage—use the
${NAMESPACE}variable.
You defineNAMESPACEat the top but hardcodejumpstarter-exportersbelow, leading to mismatches if overridden. Replace with the variable:- kubectl delete statefulset -n jumpstarter-exporters exporter vcan-exporter + kubectl delete statefulset -n "${NAMESPACE}" exporter vcan-exporter - kubectl delete pod --all -n jumpstarter-exporters --force --grace-period=0 + kubectl delete pod --all -n "${NAMESPACE}" --force --grace-period=0 - kubectl create namespace jumpstarter-exporters || true + kubectl create namespace "${NAMESPACE}" || true
♻️ Duplicate comments (3)
hack/demoenv/exporters-statefulset.yaml (1)
19-20: Consider pinning image versions for reproducible deployments.
Usinglatestcan introduce unexpected changes in production. An explicit version tag helps maintain consistency.hack/demoenv/prepare_exporters.sh (1)
60-60:⚠️ Potential issueMake
sed -iinvocation portable.
sed -i ''is macOS-specific and will fail on Linux. Replace with a portable in-place edit:- sed -i '' '/^\s*export: {}\s*$/d' "${OUT_FILE}" + sed -i '/^\s*export: {}\s*$/d' "${OUT_FILE}"hack/demoenv/kustomization.yaml (1)
20-24: ConfigMapGenerator references missing QEMU exporter config files.
The entries forgen/qemu-exporter-{0..4}.yamlmust match actual files underhack/demoenv/gen. Ensure theprepare_exporters.shrun generates these before applying, or add the files to source control.
🧹 Nitpick comments (3)
hack/demoenv/prepare_exporters.sh (1)
6-29: Remove large commented-out blocks or extract to documentation.
The loops for mock and CAN exporters are fully commented out. If these sections are no longer needed, consider deleting them or moving to a separate archival script to keep this file concise.hack/demoenv/qemu-exporters-statefulset.yaml (2)
22-24: Address the TODO or update the image reference.
The# TODOindicates you plan to switch to a continuously published image. Either remove the comment once the pipeline exists or update to the correct image path.
63-63: Add a newline at end of file.
YAML parsers and linters expect a trailing newline.🧰 Tools
🪛 Checkov (3.2.334)
[MEDIUM] 1-63: Containers should not run with allowPrivilegeEscalation
(CKV_K8S_20)
[HIGH] 1-63: Container should not be privileged
(CKV_K8S_16)
[MEDIUM] 1-63: Minimize the admission of root containers
(CKV_K8S_23)
🪛 YAMLlint (1.37.1)
[error] 63-63: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
hack/demoenv/exporters-statefulset.yaml(1 hunks)hack/demoenv/kustomization.yaml(2 hunks)hack/demoenv/prepare_exporters.sh(1 hunks)hack/demoenv/qemu-exporters-statefulset.yaml(1 hunks)hack/demoenv/vcan-exporters-statefulset.yaml(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
hack/demoenv/qemu-exporters-statefulset.yaml
[MEDIUM] 1-63: Containers should not run with allowPrivilegeEscalation
(CKV_K8S_20)
[HIGH] 1-63: Container should not be privileged
(CKV_K8S_16)
[MEDIUM] 1-63: Minimize the admission of root containers
(CKV_K8S_23)
🪛 YAMLlint (1.37.1)
hack/demoenv/qemu-exporters-statefulset.yaml
[warning] 51-51: wrong indentation: expected 6 but found 8
(indentation)
[error] 63-63: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: e2e-tests (ubuntu-24.04-arm)
- GitHub Check: e2e-tests (ubuntu-24.04)
- GitHub Check: e2e-tests-28d6b1cc3b49ab9ae176918ab9709a2e2522c97e
🔇 Additional comments (6)
hack/demoenv/vcan-exporters-statefulset.yaml (2)
19-20: Consider pinning image versions for reproducible deployments.
Switching to thelatesttag can lead to non-deterministic rollouts. If auditability or rollback safety is a priority, you may want to pin to a specific semver (e.g.,0.6.0).
25-25: Command substitution is correct, good update.
The switch tojmp run --exporter $(cat /etc/hostname)aligns with the new CLI and properly resolves the container’s hostname.hack/demoenv/exporters-statefulset.yaml (1)
25-25: Command substitution is correct, nice work.
Switching fromjmp-exporter runtojmp run --exporter $(cat /etc/hostname)reflects the updated CLI usage.hack/demoenv/qemu-exporters-statefulset.yaml (2)
24-27: Verify privileged container requirements and security context.
Running as privileged introduces security risks. If QEMU access to/dev/kvmand/dev/vhost-vsockis required, consider:
- Adding
allowPrivilegeEscalation: false- Limiting capabilities rather than full privilege
Please confirm these settings meet your security policies.
38-38: Command looks good.
Runningjmp run --exporter $(cat /etc/hostname)matches the pattern in other manifests and properly resolves the hostname.hack/demoenv/kustomization.yaml (1)
6-6: Added QEMU exporter StatefulSet to resources—looks correct.
The newqemu-exporters-statefulset.yamlis referenced alongside the existing resources.
| volumes: | ||
| - name: exporter-configs | ||
| configMap: | ||
| name: exporter-configs |
There was a problem hiding this comment.
Fix YAML indentation for volume definitions.
YAML lint reports incorrect indentation under volumes:. Align the list items two spaces under the parent key.
🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 51-51: wrong indentation: expected 6 but found 8
(indentation)
🤖 Prompt for AI Agents
In hack/demoenv/qemu-exporters-statefulset.yaml between lines 50 and 53, the
indentation of the volume list under the volumes key is incorrect, which can
cause YAML parsing errors. Fix the indentation by ensuring the dash and nested
keys are indented two spaces under the volumes key, aligning with YAML syntax
standards.
a776220 to
282729c
Compare
Add basic intel qemu exporters, and update the CLI to latest versions.
mangelajo
force-pushed
the
deploy-exporters-0.6
branch
from
282729c to
591826f
Compare
| containers: | ||
| - name: jumpstarter-exporter | ||
| # TODO: we need a continuous release of this image in jumpstarter. i.e. quay.io/jumpstarter/jumpstarter-with-qemu:latest | ||
| image: quay.io/mangelajo/jumpstarter:rel6-qemu |
There was a problem hiding this comment.
Summary by CodeRabbit