This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Update client.proto to include lease time left#30
Closed
Conversation
WalkthroughAdds an OUTPUT_ONLY optional Duration field time_left (field 12) to the Lease message in proto/jumpstarter/client/v1/client.proto. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant S as Lease Service
note over S: Server computes remaining lease time
C->>S: GetLease / WatchLease
S->>S: Calculate time_left = end_time - now()
S-->>C: Lease { id, start_time, end_time, time_left (OUTPUT_ONLY) }
rect rgba(220,240,255,0.5)
note right of C: time_left is read-only and not set by clients
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit