endtime

[michalskrivanek]

for jumpstarter-dev/jumpstarter-controller#168

Summary by CodeRabbit

• New Features
  • Lease duration is now optional, allowing creation or update of leases without specifying a duration. Systems may apply sensible defaults where omitted.
  • Improves flexibility and compatibility for clients that cannot or do not provide a duration.

[coderabbitai]

Walkthrough

The Lease message in proto/jumpstarter/client/v1/client.proto updates the duration field: it removes the REQUIRED google.api.field_behavior option and marks the field as optional, changing presence semantics without other structural modifications.

Changes

Cohort / File(s)	Summary of Changes
Lease duration presence change proto/jumpstarter/client/v1/client.proto	In message Lease, field duration changed from google.protobuf.Duration duration = 3 [(google.api.field_behavior) = REQUIRED]; to optional google.protobuf.Duration duration = 3;, removing the REQUIRED annotation and enabling field presence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add Lease related methods to client service #17 — Also edits Lease in the same proto, adding UpdateLease/DeleteLease and modifying selector; adjacent to this field presence change.
• Lease: make selector a required field, change type to string #18 — Modifies Lease selector field presence/type; overlaps in the same message and file.

Suggested reviewers

• mangelajo

Poem

A hop and a nibble, I tweak with delight,
Duration now optional—less rigid, more light.
Carrots compile, protobufs align,
Fields wave hello with presence divine.
Thump-thump the build, green lights in sight!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title "endtime" is vague and does not summarize the primary change, which involves making the Lease.duration field optional in the client.proto file. Because it does not relate to or convey the key modification, it fails to accurately describe the pull request.	Please update the title to clearly reflect the change to the Lease.duration field, for example “Make Lease.duration optional in proto/jumpstarter/client/v1/client.proto.”

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e34d86a and 8cccfa6.

📒 Files selected for processing (1)

• proto/jumpstarter/client/v1/client.proto (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• proto/jumpstarter/client/v1/client.proto

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f8035c and e34d86a.

📒 Files selected for processing (2)

• proto/jumpstarter/client/v1/client.proto (1 hunks)
• proto/jumpstarter/v1/jumpstarter.proto (1 hunks)