Hashes: ALT-F to show files in selected commits #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to view and select files from the currently selected commits in the hashes view by pressing ALT-F. This provides more flexibility compared to approaches that work with "last N commits" by allowing users to first select specific commits of interest, then view the files affected by those commits.
Key Changes:
- Added ALT-F keybinding to the hashes view that transitions to a file selection view showing files from selected commits
- Implemented
_fzf_git_tree_files()function that lists unique files across multiple commits - Enhanced output handling to support switching between hash and file selection modes using a marker pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often want to view and select the files affected by a chosen set of commits.
There's a similar attempt in fzf.vim (junegunn/fzf.vim#1606), but it's limited to the "last N" commits, which to me feels a bit arbitrary and restrictive. This approach instead works with the currently selected commits, giving more flexibility and control. One trade-off is that we can't easily generate and render the combined diffs across those commits in the preview window. So we just show the file contents.