Support old uname in macOS #4492
Conversation
|
Thanks! |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [junegunn/fzf](https://github.com/junegunn/fzf) | patch | `v0.65.1` -> `v0.65.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>junegunn/fzf (junegunn/fzf)</summary> ### [`v0.65.2`](https://github.com/junegunn/fzf/releases/tag/v0.65.2): 0.65.2 [Compare Source](junegunn/fzf@v0.65.1...v0.65.2) - Bug fixes and improvements - Fix incorrect truncation of `--info-command` with `--info=inline-right` ([#​4479](junegunn/fzf#4479)) - \[install] Support old uname in macOS ([#​4492](junegunn/fzf#4492)) - \[bash 3] Fix `CTRL-T` and `ALT-C` to preserve the last yank ([#​4496](junegunn/fzf#4496)) - Do not unset `FZF_DEFAULT_*` variables when using winpty ([#​4497](junegunn/fzf#4497)) ([#​4400](junegunn/fzf#4400)) - Fix rendering of items with tabs when using a non-default ellipsis ([#​4505](junegunn/fzf#4505)) - **This is the final release to support Windows 7.** - Future versions will be built with the latest Go toolchain, which has dropped support for Windows 7. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45MC4wIiwidXBkYXRlZEluVmVyIjoiNDEuOTAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
|
Hi @yous, a quick question. You still running Catalina? I recently decided to upgrade the Go toolchain to update the dependencies, so the new versions probably will not build or run on Catalina. https://go.dev/wiki/MinimumRequirements#macos-ne-os-x-aka-darwindarwin |
|
Hi, thanks for the notice. The link says Go 1.21 and later support 10.15 Catalina or newer, so my machine can run more future releases. 10.13 High Sierra and 10.14 Mojave may not be able to run the new versions, but I don't have actual machines running on that macOS versions. |
|
Unfortunately, we recently updated to Go 1.23 due to tcell depencency. But I don't think tcell definitely needs Go 1.23. I can attempt to fork it and maintain a version compatible with Go 1.21. |
|
I guess Go's release policy is quite aggressive. Only the last two major releases are supported. Because of this, dependencies like golang.org/x/text already require 1.24.0. But I don't think https://go.dev/wiki/MinimumRequirements is aggresive, Big Sur is released in 2020 and the support is ended. I don't have preference if fzf supports Catalina or not, as macOS Catalina is so outdated and not supported version. I will pin fzf version for that machine when it drops Go 1.21. But providing bug fixes for older versions may require maintaining multiple branches, so I think it's easier to make fzf more compatible and maintain only one branch. Still I think Go 1.23 is a reasonable starting point. |
|
Thanks for the feedback. I've opened a pull request to downgrade to Go 1.21, but I don't know if it's the right thing to do. |
2 participants
./install --allexit with error code because ofuname -smoin macOS 10.15.7, 12.7.6 (yes, they're old).man unamedoesn't contain-ooption in macOS 10.15.7, 12.7.6. I can confirm thatman unamecontain-ooption in macOS 15.6.So we can fallback to
uname -smafter tryinguname -smo.