fix: Wrong placement of 'ANSI colour off' with --no-hscroll when the string contains zero-width characters
#4646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using --no-hscroll with --ansi, the color offset constraints were incorrectly using display width (maxWidth) instead of character indices (len(runes)). This caused colors to be cut off prematurely when the text contained zero-width characters like combining marks or control characters. The fix changes the offset constraints to use the actual character count of the trimmed runes array, ensuring colors properly cover all visible characters regardless of zero-width characters. Fixes junegunn#4620 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4620
Changes
--no-hscrollmode to use character indices instead of display width