-
Notifications
You must be signed in to change notification settings - Fork 39
feat: cross-machine usage aggregation + automatic sync #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yeachan-Heo
wants to merge
14
commits into
junhoyeo:main
Choose a base branch
from
Yeachan-Heo:feat/cross-machine-aggregation-sync
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2f86c2d
feat(cli): add --quiet flag to submit for cron compatibility
Yeachan-Heo 169f405
fix(frontend): track per-device contributions for proper cross-machin…
Yeachan-Heo a027508
feat(cli): add tokscale sync command for automatic hourly submissions
Yeachan-Heo 5646e1b
docs: add automatic sync and cross-machine aggregation documentation
Yeachan-Heo fa29476
fix: address Oracle review - prevent double-count, shell injection, c…
Yeachan-Heo 48dd15e
fix: address Oracle review round 2 - defensive defaults, cron marker,…
Yeachan-Heo 3ccf761
fix: address Oracle review round 3 - legacy inherits to current devic…
Yeachan-Heo 9f7ca83
fix: preserve other devices contributions in merge, proper legacy mig…
Yeachan-Heo 7eb3e77
fix: restore __legacy__ migration to preserve historical data, add ty…
Yeachan-Heo 6b177e9
fix: handle empty devices aggregation, complete type coercion
Yeachan-Heo 6591b0e
fix: complete type coercion in route.ts aggregation
Yeachan-Heo 5f932fc
fix: address security and stability issues in cross-machine sync
junhoyeo a14f5cf
chore: merge main into PR branch, resolve conflicts
junhoyeo 46e2e43
refactor: remove --quiet flag from submit command
junhoyeo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The new
--intervalflag is accepted but ignored:setupSyncdoes not use the interval and the cron entry is hard-coded to hourly. Either implement interval handling or remove the flag to avoid misleading users.Prompt for AI agents
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the issue by removing the misleading
--intervalflag from thesync setupcommand.The problem: The
--intervalflag was accepted by the CLI but completely ignored. The cron entry was hard-coded to0 * * * *(hourly at minute 0), and thesetupSync()function parameter was prefixed with underscore (_options) indicating it was unused.The fix: Removed the flag entirely rather than implementing interval handling, because:
Changes made:
packages/cli/src/cli.ts: Removed--intervaloption and simplified the action handlerpackages/cli/src/sync.ts: RemovedSyncSetupOptionsinterface and simplifiedsetupSync()signatureFiles changed:
packages/cli/src/cli.ts— Removed --interval option from sync setup commandpackages/cli/src/sync.ts— Removed SyncSetupOptions interface and simplified setupSync() function signature