Prune stack traces up to test or lifecycle method #4829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
prune-stacktraces-up-to-test-method
branch
2 times, most recently
from
dc3215e to
888f91f
Compare
mpkorstanje
changed the title
mpkorstanje
force-pushed
the
prune-stacktraces-up-to-test-method
branch
from
888f91f to
dfe4ade
Compare
Everything before the test method is invoked is not informative for the end user. Discarding that part of the stacktrace removes a few more frames. Additionally, when pruning consider the source of the test descriptor not merely its ancestors. Fixes: junit-team#4828
mpkorstanje
force-pushed
the
prune-stacktraces-up-to-test-method
branch
from
dfe4ade to
13d039d
Compare
marcphilipp
approved these changes
Aug 14, 2025
sormuras
approved these changes
Aug 14, 2025
|
Thanks, @mpkorstanje! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything before the test method is invoked is not informative for the end user. Discarding that part of the stacktrace removes a few more uninformative frames.
Additionally, when pruning consider the source of the test descriptor not merely its ancestors.
Fixes: #4828
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations