Skip to content

Stabilize asciidoctorPdf task #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2025
+7 −3
Merged

Stabilize asciidoctorPdf task #5132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e49f52
Fix specific heap requirement of :documentation:asciidoctorPdf
TWiStErRob Nov 2, 2025
4cfad9d
Remove outdated metaspace workaround for Asciidoctor/JRuby
TWiStErRob Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion documentation/documentation.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,12 @@ tasks {
}

asciidoctorPdf {
setExecutionMode(JAVA_EXEC) // Avoid classpath conflicts with other Gradle plugins (e.g. JReleaser)
// Avoid classpath conflicts with other Gradle plugins (e.g. JReleaser)
// Avoid propagating apparent memory leaks in Asciidoctor/JRuby to Gradle daemon.
setExecutionMode(JAVA_EXEC)
jvm {
maxHeapSize = "512M"
}
sources {
include("user-guide/index.adoc")
}
Expand Down
3 changes: 1 addition & 2 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ version = 6.1.0-SNAPSHOT
# For backward compatibility checks
apiBaselineVersion = 6.0.1

# We need more metaspace due to apparent memory leak in Asciidoctor/JRuby
org.gradle.jvmargs=-Xmx1g -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryError
org.gradle.jvmargs=-Xmx1g -XX:+HeapDumpOnOutOfMemoryError
Copy link
Member

@marcphilipp marcphilipp Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure the workaround was only needed for asciidoctorPdf and not for asciidoctor (HTML) as well but I guess we'll find out. 😅

Copy link
Contributor Author

@TWiStErRob TWiStErRob Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point, we'll see. Hopefully it's been a while and things have been fixed. Btw, if metaspace needs a bump, it's not necessarily a leak, it's just huge JARs with too many classes on the classpath.

org.gradle.caching=true
org.gradle.parallel=true
org.gradle.configuration-cache.parallel=true
Expand Down