Allow @ResourceLock on @ClassTemplate classes #5176
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5155
This PR enables the use of
@ResourceLockon classes annotated with@ClassTemplate.Background
Currently, applying
@ResourceLockto a@ClassTemplateclass results in the following failure:This happens because
ClassTemplateInvocationTestDescriptor#getExclusiveResources()returns a non-empty set, causing the invocation descriptor to report exclusive resources even though the enclosingClassTemplateTestDescriptoralready collects and exposes them at the class level.Summary of Changes
Override
ClassTemplateInvocationTestDescriptor#getExclusiveResources()to always return an empty set.ClassTemplateTestDescriptor, so the invocation descriptor should not contribute additional exclusive resources.Add a dedicated test
classTemplateWithResourceLockExecutesSuccessfully()to verify that:@ClassTemplateclass annotated with@ResourceLockexecutes successfully.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations