-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Pin links to user guide in javadoc to specific version #5290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pin links to user guide in javadoc to specific version #5290
Conversation
0d94b3b to
71b4dd2
Compare
mpkorstanje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you have grepped to confirm that a substitution happened, I don't think you have tested by actually clicking through the documentation. 😉
937de7e to
941bf1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better! But while that does up date the Javadoc for the different project modules. The actual javadoc for the website is generated and aggregated in the documentation module. You'll want to look at documentation.gradle.kts for details.
To test you'll have to run ./gradlew antora and open the url that is logged in the console.
Signed-off-by: jinwoo22 <[email protected]>
941bf1a to
966a345
Compare
|
Looks good now.
No worries. Your changes weren't bad. The documentation of each modules goes into its javadoc.jar for that module. And it wouldn't be a bad thing to pin that documentation too. Could you please restore the code that updated those modules and add it to the current changes. You might be able to restore the code by finding the original commit in |
🔎 No tests executed 🔎🏷️ Commit: d935857 Learn more about TestLens at testlens.app. |
…h module Signed-off-by: jinwoo22 <[email protected]>
Signed-off-by: jinwoo22 <[email protected]>
|
@mpkorstanje |
Signed-off-by: jinwoo22 <[email protected]>



Fixes #5273
What's Changed?
https://docs.junit.org/currentlink in Javadoc by making it conditional on the build environment.locally built User Guide generated as part of the same build.
This allows cross-references to documentation for unreleased features to be verified locally.
point to
https://docs.junit.org/current, ensuring that published documentation remains unchanged.Below are the results showing that the links were correctly updated after building the project.
Before
After
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations