Skip to content

feat: prevent re-starting already running observatory openid monitoring #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 5 commits into from
Jan 5, 2026
Merged

feat: prevent re-starting already running observatory openid monitoring #234

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f99df80
feat: prevent re-starting already running observatory openid monitoring
peterpeterparker Jan 5, 2026
515fe38
Merge branch 'main' into feat/prevent-restart-restop
peterpeterparker Jan 5, 2026
13d2ccb
chore: lint
peterpeterparker Jan 5, 2026
c002004
chore: fmt
peterpeterparker Jan 5, 2026
5f28007
Merge branch 'main' into feat/prevent-restart-restop
peterpeterparker Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions cli/src/services/server/observatory.services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,23 @@ export const toggleOpenIdMonitoring = async ({

switch (action) {
case 'start': {
const alreadyEnabled = await isOpenIdMonitoringEnabled({context});

if (alreadyEnabled) {
return;
}

await updateRateConfig({context});
await startOpenIdMonitoring({context});
return;
}
case 'stop': {
const alreadyDisabled = await isOpenIdMonitoringDisabled({context});

if (alreadyDisabled) {
return;
}

await stopOpenIdMonitoring({context});
return;
}
Expand Down Expand Up @@ -45,6 +57,20 @@ const updateRateConfig = async ({context}: {context: CliContext}) => {
console.log('Rate config applied! ✅');
};

const isOpenIdMonitoringEnabled = async ({context}: {context: CliContext}): Promise<boolean> => {
const {agent} = context;

const {is_openid_monitoring_enabled} = await getObservatoryActor({
agent,
canisterId: OBSERVATORY_CANISTER_ID
});

return await is_openid_monitoring_enabled();
};

const isOpenIdMonitoringDisabled = async (params: {context: CliContext}): Promise<boolean> =>
!(await isOpenIdMonitoringEnabled(params));

const startOpenIdMonitoring = async ({context}: {context: CliContext}) => {
const {agent} = context;

Expand Down