feat: use Datastore for user usage#1218
Merged
peterpeterparker merged 25 commits intomainfrom Feb 10, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I think it's too early to optimize with adding an addition stable tree map plus it's a bit ironic to use another tree map when developers themselves use the main DB tree map.
Therefore this PR changes the approach for tracking and asserting user usage by using the DB tree map as well.
Features wise there is one change in regard of previous, not yet delivered, implementation: the usage will not be readable for controllers only, previous a user could read their own usage. I think that's acceptable and not fundamentaly incorrect at this point as well.