Skip to content

refactor(shared): constant canister prefix #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 2 commits into from
Jan 6, 2026
Merged

refactor(shared): constant canister prefix #2476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56aa5b1
feat(shared)!: rename CREATE_CANISTER_CYCLES
peterpeterparker Jan 6, 2026
41cccf0
feat(shared)!: rename CREATE_CANISTER_CYCLES with IC prefix
peterpeterparker Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/shared/src/constants/shared.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pub const IC_TRANSACTION_FEE_CYCLES: CyclesTokens = CyclesTokens::from_e12s(100_
// Cost for creating a canister have been increased by 400% in November 2024:
// - https://forum.dfinity.org/t/evaluating-compute-pricing-in-response-to-increased-demand-on-the-internet-computer-protocol/36565
// - https://nns.ic0.app/proposal/?u=qoctq-giaaa-aaaaa-aaaea-cai&proposal=134032
pub const CREATE_CANISTER_CYCLES: u128 = 500_000_000_000u128;
pub const IC_CREATE_CANISTER_CYCLES: u128 = 500_000_000_000u128;

// Additional cycles allocated for creating different types of canisters to ensure operation beyond the minimum requirement.
pub const CREATE_SATELLITE_CYCLES: u128 = 1_000_000_000_000;
Expand Down
4 changes: 2 additions & 2 deletions src/libs/shared/src/mgmt/settings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::constants::internal::WASM_MEMORY_LIMIT;
use crate::constants::shared::CREATE_CANISTER_CYCLES;
use crate::constants::shared::IC_CREATE_CANISTER_CYCLES;
use crate::mgmt::types::ic::CreateCanisterInitSettingsArg;
use candid::Nat;
use ic_cdk::management_canister::CanisterSettings;
Expand All @@ -24,5 +24,5 @@ pub fn create_canister_settings(
}

pub fn create_canister_cycles(cycles: u128) -> u128 {
CREATE_CANISTER_CYCLES + cycles
IC_CREATE_CANISTER_CYCLES + cycles
}
Loading