Skip to content

refactor(frontend): rename and move link to wallet info for factory #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 3 commits into from
Jan 7, 2026
Merged

refactor(frontend): rename and move link to wallet info for factory #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21cc730
refactor(frontend): rename and move link to wallet info for factory
peterpeterparker Jan 7, 2026
737bf5c
Merge branch 'main' into refactor/info-rename-move
peterpeterparker Jan 7, 2026
31831a5
chore: lint
peterpeterparker Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/frontend/src/lib/components/factory/create/FactoryCredits.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import { fromNullable, isNullish } from '@dfinity/utils';
import type { Snippet } from 'svelte';
import FactoryCreditsWithFee from '$lib/components/factory/create/FactoryCreditsWithFee.svelte';
import GetICPInfo from '$lib/components/wallet/GetICPInfo.svelte';
import FactoryWalletInfo from '$lib/components/factory/create/FactoryWalletInfo.svelte';
import type { SelectedWallet } from '$lib/schemas/wallet.schema';
import type { JunoModalCreateSegmentDetail, JunoModalDetail } from '$lib/types/modal';
import type { Option } from '$lib/types/utils';
Expand Down Expand Up @@ -37,7 +37,7 @@
</script>

{#if isNullish(fee)}
<GetICPInfo {onclose} />
<FactoryWalletInfo {onclose} />
{:else}
<FactoryCreditsWithFee
{fee}
Expand Down
4 changes: 2 additions & 2 deletions src/frontend/src/lib/components/factory/create/FactoryCreditsWithFee.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script lang="ts">
import type { Snippet } from 'svelte';
import FactoryWalletInfo from '$lib/components/factory/create/FactoryWalletInfo.svelte';
import Html from '$lib/components/ui/Html.svelte';
import GetICPInfo from '$lib/components/wallet/GetICPInfo.svelte';
import { E8S_PER_ICP } from '$lib/constants/app.constants';
import { CYCLES, ICP } from '$lib/constants/token.constants';
import { creditsOrZero } from '$lib/derived/console/credits.derived';
Expand Down Expand Up @@ -89,7 +89,7 @@
{/if}

{#if insufficientFunds}
<GetICPInfo {onclose} />
<FactoryWalletInfo {onclose} />
{:else}
{@render children()}
{/if}
8 changes: 1 addition & 7 deletions ...c/lib/components/wallet/GetICPInfo.svelte → ...s/factory/create/FactoryWalletInfo.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</script>

<p>
{$i18n.wallet.transfer_icp_info}
{$i18n.wallet.transfer_info}
<ExternalLink href="https://juno.build/docs/miscellaneous/wallet" underline
>{$i18n.wallet.documentation}</ExternalLink
>.
Expand All @@ -21,9 +21,3 @@
<button onclick={onclose} {...testId(testIds.wizard.closeInsufficientFunds)}
>{$i18n.core.close}</button
>

<style lang="scss">
.account-identifier {
margin: 0;
}
</style>
2 changes: 1 addition & 1 deletion src/frontend/src/lib/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@
"account_identifier": "Account identifier",
"balance": "Balance",
"credits": "Credits",
"transfer_icp_info": "Learn how to provision your wallet in the",
"transfer_info": "Learn how to provision your wallet in the",
"documentation": "documentation",
"information": "Learn about the wallet in the documentation",
"tx_id": "ID",
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/lib/i18n/zh-cn.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@
"account_identifier": "账户",
"balance": "余额",
"credits": "积分",
"transfer_icp_info": "了解如何为您的钱包充值",
"transfer_info": "了解如何为您的钱包充值",
"documentation": "文档",
"information": "在文档中了解更多钱包信息",
"tx_id": "交易ID",
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/lib/types/i18n.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ interface I18nWallet {
account_identifier: string;
balance: string;
credits: string;
transfer_icp_info: string;
transfer_info: string;
documentation: string;
information: string;
tx_id: string;
Expand Down