Skip to content

fix(frontend): loading on direct access to hosting settings #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 1 commit into from
Jan 7, 2026
Merged

fix(frontend): loading on direct access to hosting settings #2486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/frontend/src/lib/components/hosting/HostingSettings.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import { fromNullable, nonNullish } from '@dfinity/utils';
import { onMount } from 'svelte';
import { fromNullable, isNullish, nonNullish } from '@dfinity/utils';
import { onMount, untrack } from 'svelte';

Check warning on line 3 in src/frontend/src/lib/components/hosting/HostingSettings.svelte

View workflow job for this annotation

GitHub Actions / lint 

'onMount' is defined but never used. Allowed unused vars must match /^_/u
import { fade } from 'svelte/transition';
import type { SatelliteDid } from '$declarations';
import HostingSwitchMemory from '$lib/components/hosting/HostingSwitchMemory.svelte';
Expand All @@ -9,6 +9,7 @@
import { authIdentity } from '$lib/derived/auth.derived';
import { getRuleDapp } from '$lib/services/satellite/collection.services';
import { i18n } from '$lib/stores/app/i18n.store';
import { versionStore } from '$lib/stores/version.store';
import type { Satellite } from '$lib/types/satellite';

interface Props {
Expand All @@ -26,15 +27,22 @@
let memory = $derived(fromNullable(rule?.memory ?? []));

const loadRule = async () => {
if (isNullish($authIdentity) || $versionStore?.satellites[satelliteId.toText()] === undefined) {
return;
}

const result = await getRuleDapp({ satelliteId, identity: $authIdentity });
rule = result?.rule;
supportSettings = result?.result === 'success';

loading = false;
};

onMount(() => {
loadRule();
$effect(() => {
$authIdentity;
$versionStore;

untrack(loadRule);
});
</script>

Expand Down