Skip to content

Conversation

@tinkerer-shubh
Copy link
Contributor

Motivation

This PR refines the error handling logic within the storage library's HTTP response generation.

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Jan 8, 2026

While the current implementation that uses unwrap clearly needs a review, absolutely agree, I'd rather integrate it and related error handling in the context of issue #1384. Furthermore, this PR does not really addresses its goal as adding a response which is uncertified isn't really going to improve the HTTP response as it won't be valid anyway. Certification is a tricky subject.

Lastly, any changes in the backend require providing tests.

For those reasons, I'd rather close this submission, but thanks for it anyway.

@tinkerer-shubh tinkerer-shubh deleted the fix/http-response-error-handling branch January 8, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants