Add create_notebook function to notebook toolkit #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures consistent filepath handling across all toolkit functions by using the normalize_filepath utility function. This handles URL-encoded paths, relative paths, and special characters consistently. - Updated file_system toolkit: read, write, edit, search_and_replace, glob, grep, ls - Updated notebook toolkit: all functions that take file_path parameter - Updated git toolkit: all functions that take path parameter - Added comprehensive tests for normalize_filepath functionality All tools now properly decode URL-encoded paths (e.g., my%20notebook.ipynb → my notebook.ipynb) and resolve relative paths against the Jupyter server's root directory.
This function creates a new empty Jupyter notebook at the specified file path with proper nbformat structure, including directory creation if needed.
3coins
reviewed
Aug 8, 2025
|
|
||
| # Resolve relative path against the root directory | ||
| resolved_path = Path(root_dir) / path | ||
| return str(resolved_path.resolve()) |
Contributor
There was a problem hiding this comment.
Should we check if the path stays within root directory?
Suggested change
| return str(resolved_path.resolve()) | |
| if not str(resolved_path).startswith(str(root_path)): | |
| raise ValueError(f"{file_path} resolves outside Jupyter root directory") | |
| return str(resolved_path.resolve()) |
Comment on lines
+47
to
+48
| # URL decode the path in case it contains encoded characters | ||
| decoded_path = unquote(file_path) |
Contributor
There was a problem hiding this comment.
Can do a slight optimization here, to skip decoding for abs paths.
Suggested change
| # URL decode the path in case it contains encoded characters | |
| decoded_path = unquote(file_path) | |
| if os.path.isabs(file_path) and '%' not in file_path: | |
| return str(Path(file_path).resolve()) | |
| # URL decode the path in case it contains encoded characters | |
| decoded_path = unquote(file_path) |
3coins
reviewed
Aug 8, 2025
| return server | ||
|
|
||
|
|
||
| def normalize_filepath(file_path: str) -> str: |
Contributor
There was a problem hiding this comment.
Might benefit from caching, since this is called in numerous places.
Suggested change
| def normalize_filepath(file_path: str) -> str: | |
| @functools.lru_cache(maxsize=256) | |
| def normalize_filepath(file_path: str) -> str: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
create_notebookfunction to notebook toolkit that creates new empty Jupyter notebooks