Skip to content

Conversation

@3coins
Copy link
Contributor

@3coins 3coins commented Oct 29, 2025

No description provided.

pyproject.toml Outdated
"jupyter_server>=1.6,<3",
"jupyterlab_git",
"jupyter_ai>=3.0.0-beta.1"
"jupyter_server_documents>=0.1.a8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is jupyter_server_documents a requirement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the ydoc is being pulled from yroom_manager.
https://github.com/jupyter-ai-contrib/jupyter-ai-tools/blob/main/jupyter_ai_tools/utils.py#L69-L85

We can make it compatible with collaboration with a small change, let me update this.

Copy link
Contributor

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3coins This looks good. Approving here, but I think we should remove jupyter-server-documents as a requirement.

@3coins
Copy link
Contributor Author

3coins commented Oct 30, 2025

@Zsailer
Updated.

@Zsailer
Copy link
Contributor

Zsailer commented Oct 30, 2025

Thank you! Looks great!

@Zsailer Zsailer merged commit 8f05c53 into jupyter-ai-contrib:main Oct 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants