-
Notifications
You must be signed in to change notification settings - Fork 3
Simplified toolkits as list of tools, enabled imports from root #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pyproject.toml
Outdated
| "jupyter_server>=1.6,<3", | ||
| "jupyterlab_git", | ||
| "jupyter_ai>=3.0.0-beta.1" | ||
| "jupyter_server_documents>=0.1.a8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is jupyter_server_documents a requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the ydoc is being pulled from yroom_manager.
https://github.com/jupyter-ai-contrib/jupyter-ai-tools/blob/main/jupyter_ai_tools/utils.py#L69-L85
We can make it compatible with collaboration with a small change, let me update this.
Zsailer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3coins This looks good. Approving here, but I think we should remove jupyter-server-documents as a requirement.
|
@Zsailer |
|
Thank you! Looks great! |
No description provided.