Skip to content

Conversation

@dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Oct 23, 2025

Description

I verified that these changes does not break the current experience & correctly prevents users from configuring trait values <=0.

@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 23, 2025

CI failure is not related, but it is happening on main as well.

Issue is reproducible by running cd ui-tests/ && jlpm. Looking into this now. This is the relevant error:

Resolution step
  ➤ YN0001: │ Error: vega-util@npm:^1.17.4: No candidates found
      at ge (/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/jupyterlab/staging/yarn.js:439:7784)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 23, 2025

Weird, for some reason cd ui-tests/ && jlpm is trying to pull in patch releases of vega subpackages that do not exist. For each package raising an error, the requested patch release is 1 too high. Presumably this is an upstream bug in vega.

I've added these resolutions which decrease the patch version by 1 on every package raising an error on jlpm install:

  "resolutions": {
    "vega-util": "^1.17.3",
    "vega-dataflow": "^5.7.7",
    "vega-selections": "5.6.0",
    "vega-scale": "^7.4.2",
    "vega-scenegraph": "^4.13.1",
    "vega-time": "^2.1.3"
  }

To future devs: feel free to remove these resolutions if cd ui-tests/ && jlpm passes without these resolutions.

Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Verified that notebook behavior is intact with this change.

@dlqqq dlqqq merged commit dcf8a50 into jupyter-ai-contrib:main Oct 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants