Skip to content

Comments

[SPIKE]: Try using Shiki for syntax highlighting#590

Draft
agoose77 wants to merge 2 commits intomainfrom
agoose77/spike-try-shiki
Draft

[SPIKE]: Try using Shiki for syntax highlighting#590
agoose77 wants to merge 2 commits intomainfrom
agoose77/spike-try-shiki

Conversation

@agoose77
Copy link
Collaborator

This PR is an attempt to use Shiki for syntax highlighting.

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: 3f254f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stefanv
Copy link
Collaborator

stefanv commented Nov 14, 2025

@agoose77 Did you still want to try using Shiki for syntax highlighting?

@agoose77
Copy link
Collaborator Author

@stefanv yes, I think it's much better. However, this spike was just that. We should make a more concerted effort.

@stevejpurves
Copy link
Collaborator

@agoose77 just for reference - was looking at Shiki addressing some issue with the previous renderer (I remember previous awkward build issues somewhere) or is it purely a matter of preference / stylistics?

as we are in a(the) central reusable package here, in a more concerted effort, we should probably consider enabling a choice of syntax renderer, or an opt in to shiki.

Maybe that is as simple as having multiple variants of a code renderer, and then the consuming themerenderer can pick and choose which to load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants