Skip to content

Conversation

@kp992
Copy link

@kp992 kp992 commented Jul 14, 2025

This PR tries to add exercise and solution node in md converter. The error looks like:

⛔️ exports/a.ipynb Unsupported node type: exercise
⛔️ exports/a.ipynb Unsupported node type: solution

cc @agoose77 @mmcky

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: d9e208d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kp992
Copy link
Author

kp992 commented Jul 14, 2025

The diff fixes the error but the output is still empty. So I believe I might need to fix directiveHandlers, can you please review @agoose77?

Thank you.

@kp992
Copy link
Author

kp992 commented Aug 3, 2025

@agoose77 I have updated the PR with some tests. Can you please review and share your suggestions and improvements?

"vfile": "^5.3.7",
"vfile-reporter": "^7.0.4"
"vfile-reporter": "^7.0.4",
"myst-ext-exercise": "^1.0.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good in general! I am trying to think of a way to not have the extension as a dependency?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @rowanc1. Hmm, do you have any suggestions for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants