-
Notifications
You must be signed in to change notification settings - Fork 124
Support exercise and solution node in myst-to-md
#2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: myst-to-ipynb
Are you sure you want to change the base?
Conversation
|
|
The diff fixes the error but the output is still empty. So I believe I might need to fix Thank you. |
|
@agoose77 I have updated the PR with some tests. Can you please review and share your suggestions and improvements? |
| "vfile": "^5.3.7", | ||
| "vfile-reporter": "^7.0.4" | ||
| "vfile-reporter": "^7.0.4", | ||
| "myst-ext-exercise": "^1.0.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good in general! I am trying to think of a way to not have the extension as a dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @rowanc1. Hmm, do you have any suggestions for that?
This PR tries to add exercise and solution node in
mdconverter. The error looks like:cc @agoose77 @mmcky