Skip to content

🔐 Use npm ci instead of npm install for theme dependencies #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🔐 Use npm ci instead of npm install for theme dependencies #2487

wants to merge 2 commits into from

Conversation

@stefanv
Copy link
Collaborator

@stefanv stefanv commented Nov 25, 2025 •
edited by agoose77
Loading

Closes #2493

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e31dbe4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfisher87
Copy link
Contributor

mfisher87 commented Nov 25, 2025

You rock, Stefan :)

@rowanc1 rowanc1 added the enhancement New feature or request label Nov 25, 2025
@rowanc1 rowanc1 changed the title Use npm ci instead of npm install for theme dependencies 🔐 Use npm ci instead of npm install for theme dependencies Nov 25, 2025
mfisher87
mfisher87 reviewed Nov 25, 2025
View reviewed changes
@stefanv
Copy link
Collaborator Author

stefanv commented Nov 25, 2025

Just trying Rowan's suggestion :)

There will likely be some subtleties to tweak.

@agoose77
Copy link
Contributor

agoose77 commented Nov 25, 2025

We'll need to update the template.yml in themes/*/template.yml too, in myst-theme.

stefanv added a commit to stefanv/myst-theme that referenced this pull request Nov 25, 2025
@stefanv
Use npm ci instead of npm install for themes
0747785 
xref: jupyter-book/mystmd#2487
@stefanv stefanv mentioned this pull request Nov 25, 2025
Open
@stefanv
Copy link
Collaborator Author

stefanv commented Nov 25, 2025

We'll need to update the template.yml in themes/*/template.yml too, in myst-theme.

Thanks! Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mfisher87 mfisher87 mfisher87 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

PR triage (experimental)
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable lifecycle scripts when installing packages for MyST templates

4 participants

@stefanv @mfisher87 @agoose77 @rowanc1