🚛 migrate xrefs #2551
Open
🚛 migrate xrefs #2551
+139
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ee7fc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
The test failure is real, will address if we want to bring this in cc @agoose77 |
rowanc1
force-pushed
the
feat/migrate-external-content
branch
from
358c383 to
235245a
Compare
stevejpurves
force-pushed
the
feat/migrate-external-content
branch
from
235245a to
fb5d6bb
Compare
Contributor
Author
|
My last commit updated the test snapshot which i expected to fix the failure, but it has not. I am not clear on why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply applies the migration functionality that we already have in Myst migrate to incoming content from xrefs.
We had made a decision not to upgrade previous content automatically within the theme. However, when it comes to xrefs, the lack of this results in a DOM, in an AST that contains basically invalid nodes or nodes that don't conform to the overall AST version being advertised at the root level.Which is particularly bad.
Tested using xrefs to V2 content from a V3 AST.