🚛 migrate xrefs #2551
🚛 migrate xrefs #2551
Conversation
🦋 Changeset detectedLatest commit: 9ee7fc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The test failure is real, will address if we want to bring this in cc @agoose77 |
rowanc1
force-pushed
the
feat/migrate-external-content
branch
from
358c383 to
235245a
Compare
stevejpurves
force-pushed
the
feat/migrate-external-content
branch
from
235245a to
fb5d6bb
Compare
|
My last commit updated the test snapshot which i expected to fix the failure, but it has not. I am not clear on why. |
| "type": "outputs", | ||
| "children": [ |
rowanc1
left a comment
rowanc1
left a comment
There was a problem hiding this comment.
I think in the future we might want some better ways to do these test cases.
Right now these are dependent on the docs, which need their own upgrades!
|
Thanks @rowanc1 for educating me on the upgrade infra on the community call. This now makes a lot of sense, and happy that it provides some future-proofing! |
This PR simply applies the migration functionality that we already have in Myst migrate to incoming content from xrefs.
We had made a decision not to upgrade previous content automatically within the theme. However, when it comes to xrefs, the lack of this results in a DOM, in an AST that contains basically invalid nodes or nodes that don't conform to the overall AST version being advertised at the root level.Which is particularly bad.
Tested using xrefs to V2 content from a V3 AST.