restore prettier <2 arrowParens behavior

Author: bollwyvl

package.json

@@ -29,6 +29,7 @@
     }
   },
   "prettier": {
+    "arrowParens": "avoid",
     "singleQuote": true,
     "trailingComma": "none"
   },

packages/jupyterlab-go-to-definition/src/index.ts

@@ -61,7 +61,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
       // more reasonable thing would be to create a PR with .onAddCell
       setTimeout(() => {
         // now (notebook.widgets.length is likely > 1)
-        notebook.widgets.every((cell) => {
+        notebook.widgets.every(cell => {
           let codemirror_editor = cell.editor as CodeMirrorEditor;
           let extension = new CodeMirrorExtension(codemirror_editor, jumper);
 
@@ -86,7 +86,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
 
     function updateOptions(settings: ISettingRegistry.ISettings): void {
       let options = settings.composite;
-      Object.keys(options).forEach((key) => {
+      Object.keys(options).forEach(key => {
         if (key === 'modifier') {
           let modifier = options[key] as KeyModifier;
           CodeMirrorExtension.modifierKey = modifier;
@@ -96,7 +96,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
 
     settingRegistry
       .load(plugin.id)
-      .then((settings) => {
+      .then(settings => {
         updateOptions(settings);
         settings.changed.connect(() => {
           updateOptions(settings);
@@ -221,7 +221,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
       }
     ];
 
-    bindings.map((binding) => app.commands.addKeyBinding(binding));
+    bindings.map(binding => app.commands.addKeyBinding(binding));
   },
   autoStart: true
 };

packages/jupyterlab-go-to-definition/src/jumpers/jumper.ts

@@ -140,7 +140,7 @@ export abstract class CodeJumper {
         let filtered = in_earlier_cell
           ? definitions // all are in an earlier cell
           : definitions.filter(
-              (otherToken) => otherToken.offset < originToken.offset
+              otherToken => otherToken.offset < originToken.offset
             ); // all are in same cell
 
         // but ignore ones that are part of the same assignment expression,
@@ -149,7 +149,7 @@ export abstract class CodeJumper {
         // >>> a = a + 1
         // clicking on the last 'a' should jump to the first line,
         // and not to beginning of the second line.
-        filtered = filtered.filter((otherToken) => {
+        filtered = filtered.filter(otherToken => {
           // If otherToken is in previous cell, we don't need to worry.
           if (i < stopIndex) {
             return true;
@@ -243,7 +243,7 @@ export abstract class CodeJumper {
               });
 
               dialog_promise
-                .then((result) => {
+                .then(result => {
                   if (result.button.accept) {
                     disposable.dispose();
                   }
@@ -335,7 +335,7 @@ export abstract class CodeJumper {
     let potential_paths = cell_of_origin_analyzer.guessReferencePath(context);
     if (this.cwd) {
       let prefixed_with_cwd = potential_paths.map(
-        (path) => this.cwd + '/' + path
+        path => this.cwd + '/' + path
       );
       potential_paths = prefixed_with_cwd.concat(potential_paths);
     }
@@ -346,7 +346,7 @@ export abstract class CodeJumper {
       this.queryKernel(
         code,
         this.kernel,
-        (msg) => this.handle_path_from_kernel(msg, potential_paths) // TODO: extract fallback?
+        msg => this.handle_path_from_kernel(msg, potential_paths) // TODO: extract fallback?
       );
     } else {
       // TODO: extract fallback?
@@ -392,7 +392,7 @@ export abstract class CodeJumper {
     let code = cell_of_origin_analyzer.definitionLocationQuery(context);
 
     if (cell_of_origin_analyzer.supportsKernel && this.kernel && code) {
-      this.queryKernel(code, this.kernel, (msg) =>
+      this.queryKernel(code, this.kernel, msg =>
         this.handle_kernel_inspect(msg, fallback)
       );
     } else {

packages/jupyterlab-go-to-definition/src/jumpers/notebook.ts

@@ -35,7 +35,7 @@ export class NotebookJumper extends CodeJumper {
   }
 
   get editors() {
-    return this.notebook.widgets.map((cell) => cell.editor);
+    return this.notebook.widgets.map(cell => cell.editor);
   }
 
   get language() {

packages/jupyterlab-go-to-definition/src/languages/analyzer.ts

@@ -114,7 +114,7 @@ export abstract class LanguageAnalyzer {
   _get_token_index(token: CodeEditor.IToken) {
     this._maybe_setup_tokens();
     return this.tokens.findIndex(
-      (t) =>
+      t =>
         t.value === token.value &&
         t.offset === token.offset &&
         t.type === token.type
@@ -211,7 +211,7 @@ export abstract class LanguageAnalyzer {
     let terminatingTokens = this._selectTerminatingTokens(tokensBetween);
 
     let terminatorsAfterAssignment = terminatingTokens.filter(
-      (token) => token.offset > firstAssignment.offset
+      token => token.offset > firstAssignment.offset
     );
 
     if (!terminatorsAfterAssignment.length) {

packages/jupyterlab-go-to-definition/src/languages/r.spec.ts

@@ -22,7 +22,7 @@ describe('RAnalyzer', () => {
   ) {
     let tokens = tokensProvider.getTokens();
     let matchedTokens = tokens.filter(
-      (token) => token.value === tokenName && token.type === tokenType
+      token => token.value === tokenName && token.type === tokenType
     );
     let token = matchedTokens[tokenOccurrence - 1];
     let tokenId = tokens.indexOf(token);

packages/jupyterlab-go-to-definition/src/notebook_private.ts

@@ -37,7 +37,7 @@ function _findCell(notebook: Notebook, node: HTMLElement): number {
     if (node.classList.contains(NB_CELL_CLASS)) {
       let i = ArrayExt.findFirstIndex(
         notebook.widgets,
-        (widget) => widget.node === node
+        widget => widget.node === node
       );
       if (i !== -1) {
         return i;

packages/jupyterlab-go-to-definition/src/testutils.ts

@@ -9,7 +9,7 @@ export function matchToken(
   tokenType = 'variable'
 ): CodeEditor.IToken {
   let matchedTokens = tokens.filter(
-    (token) => token.value === tokenName && token.type === tokenType
+    token => token.value === tokenName && token.type === tokenType
   );
   return matchedTokens[tokenOccurrence - 1];
 }

packages/jupyterlab-lsp/src/adapters/codemirror/feature.ts

@@ -288,7 +288,7 @@ export abstract class CodeMirrorLSPFeature implements ILSPFeature {
     // Specs: documentChanges are preferred over changes
     let changes = workspaceEdit.documentChanges
       ? workspaceEdit.documentChanges.map(
-          (change) => change as lsProtocol.TextDocumentEdit
+          change => change as lsProtocol.TextDocumentEdit
         )
       : toDocumentChanges(workspaceEdit.changes);
     let applied_changes = null;

packages/jupyterlab-lsp/src/adapters/codemirror/features/diagnostics.spec.ts

@@ -149,7 +149,7 @@ describe('Diagnostics', () => {
       });
 
       let cm_editors = env.virtual_editor.notebook.widgets.map(
-        (cell) => (cell.editor as CodeMirrorEditor).editor
+        cell => (cell.editor as CodeMirrorEditor).editor
       );
       let marks_cell_1 = cm_editors[0].getDoc().getAllMarks();
       // test from mypy, test from pyflakes, whitespace around operator from pycodestyle
@@ -213,7 +213,7 @@ describe('Diagnostics', () => {
       // test guards against wrongly propagated responses:
       feature.handleDiagnostic(response);
       let cm_editors = env.virtual_editor.notebook.widgets.map(
-        (cell) => (cell.editor as CodeMirrorEditor).editor
+        cell => (cell.editor as CodeMirrorEditor).editor
       );
 
       let marks_cell_1 = cm_editors[0].getDoc().getAllMarks();