don't lint dist, restore ts-ignore and interface-name (with grandfathered usage)

Author: bollwyvl

packages/.eslintrc.js

@@ -57,13 +57,12 @@ module.exports = {
     'no-useless-escape': 'off',
     'prefer-const': 'off',
     // deviations from jupyterlab, should probably be fixed
-    'jest/valid-expect': 'off',
+    '@typescript-eslint/triple-slash-reference': 'off',
     'jest/no-test-callback': 'off',
-    '@typescript-eslint/ban-ts-ignore': 'off',
-    'react/display-name': 'off',
+    'jest/valid-expect': 'off',
+    'no-async-promise-executor': 'off',
     'prefer-spread': 'off',
-    '@typescript-eslint/triple-slash-reference': 'off',
-    'no-async-promise-executor': 'off'
+    'react/display-name': 'off'
   },
   settings: {
     react: {

packages/jupyterlab-lsp/src/adapters/codemirror/feature.ts

@@ -163,6 +163,7 @@ export abstract class CodeMirrorLSPFeature implements ILSPFeature {
   static readonly commands = new Array<IFeatureCommand>();
 
   /* Just a safeguard to enforce static commands in sub-classes */
+  // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
   // @ts-ignore
   private commands: any;
 

packages/jupyterlab-lsp/src/adapters/jupyterlab/components/free_tooltip.ts

@@ -22,6 +22,7 @@ interface IFreeTooltipOptions extends Tooltip.IOptions {
 /**
  * Tooltip which can be placed  at any character, not only at the current position (derived from getCursorPosition)
  */
+// eslint-disable-next-line @typescript-eslint/ban-ts-ignore
 // @ts-ignore
 export class FreeTooltip extends Tooltip {
   position: CodeEditor.IPosition | null;
@@ -33,9 +34,11 @@ export class FreeTooltip extends Tooltip {
     this.movetoLineEnd = options.moveToLineEnd;
   }
 
+  // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
   // @ts-ignore
   private _setGeometry(): void {
     // Find the start of the current token for hover box placement.
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
     // @ts-ignore
     const editor = this._editor as CodeEditor.IEditor;
     const cursor: CodeEditor.IPosition =

packages/jupyterlab-lsp/src/adapters/jupyterlab/jl_adapter.ts

@@ -506,6 +506,7 @@ export abstract class JupyterLabWidgetAdapter
 
     let { left, top } = leaf_node.getBoundingClientRect();
 
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
     // @ts-ignore
     let event = this.app._contextMenuEvent;
 

packages/jupyterlab-lsp/src/extractors/regexp.ts

@@ -42,13 +42,15 @@ export class RegExpForeignCodeExtractor implements IForeignCodeExtractor {
       let position_shift: CodeEditor.IPosition = null;
       let foreign_code_fragment = matched_string.replace(
         this.expression,
+        // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
         // @ts-ignore
         this.options.extract_to_foreign
       );
       let prefix = '';
       if (typeof this.options.extract_arguments !== 'undefined') {
         prefix = matched_string.replace(
           this.expression,
+          // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
           // @ts-ignore
           this.options.extract_arguments
         );

packages/jupyterlab-lsp/src/lsp.ts

@@ -42,6 +42,7 @@ export namespace DocumentHighlightKind {
 export function inverse_namespace(namespace: object): Record<number, string> {
   const records: Record<number, string> = {};
   for (let key of Object.keys(namespace)) {
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
     // @ts-ignore
     records[namespace[key]] = key;
   }

packages/jupyterlab-lsp/src/magics/maps.ts

@@ -10,6 +10,7 @@ abstract class MagicsMap extends Map<RegExp, string | replacer> {
   protected _override_for(code: string): string | null {
     for (let [key, value] of this) {
       if (code.match(key)) {
+        // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
         // @ts-ignore
         return code.replace(key, value);
       }

packages/jupyterlab-lsp/src/virtual/editors/notebook.ts

@@ -11,6 +11,7 @@ import {
   IVirtualPosition
 } from '../../positioning';
 
+// eslint-disable-next-line @typescript-eslint/ban-ts-ignore
 // @ts-ignore
 class DocDispatcher implements CodeMirror.Doc {
   virtual_editor: VirtualEditorForNotebook;
@@ -185,8 +186,10 @@ export class VirtualEditorForNotebook extends VirtualEditor {
 
   addPanel(
     node: HTMLElement,
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
     // @ts-ignore
     options?: CodeMirror.ShowPanelOptions
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
     // @ts-ignore
   ): CodeMirror.Panel {
     return undefined;
@@ -269,6 +272,7 @@ export class VirtualEditorForNotebook extends VirtualEditor {
 
   getDoc(): CodeMirror.Doc {
     let dummy_doc = new DocDispatcher(this);
+    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
     // @ts-ignore
     return dummy_doc;
   }