Merge pull request #731 from jupyter-lsp/add-dot-local-node-root

Check for `node_modules` in `~/.local/lib` or other user-defined prefix

Author: krassowski

python_packages/jupyter_lsp/jupyter_lsp/types.py

@@ -6,7 +6,9 @@
 import pathlib
 import re
 import shutil
+import subprocess
 import sys
+from functools import lru_cache
 from typing import (
     TYPE_CHECKING,
     Any,
@@ -230,6 +232,17 @@ def _default_nodejs(self):
             shutil.which("node") or shutil.which("nodejs") or shutil.which("nodejs.exe")
         )
 
+    @lru_cache(maxsize=1)
+    def _npm_prefix(self):
+        try:
+            return (
+                subprocess.run(["npm", "prefix", "-g"], check=True, capture_output=True)
+                .stdout.decode("utf-8")
+                .strip()
+            )
+        except Exception as e:  # pragma: no cover
+            self.log.warn(f"Could not determine npm prefix: {e}")
+
     @default("node_roots")
     def _default_node_roots(self):
         """get the "usual suspects" for where `node_modules` may be found
@@ -257,6 +270,15 @@ def _default_node_roots(self):
         # ... but right in %PREFIX% on nt
         roots += [pathlib.Path(sys.prefix)]
 
+        # check for custom npm prefix
+        if shutil.which("npm"):
+            prefix = self._npm_prefix()
+            if prefix:
+                roots += [  # pragma: no cover
+                    pathlib.Path(prefix) / "lib",
+                    pathlib.Path(prefix),
+                ]
+
         return roots