Fix the ctrl + click jump, clean up

Author: krassowski

package.json

@@ -38,13 +38,14 @@
   "private": true,
   "scripts": {
     "bootstrap": "jlpm --no-optional --prefer-offline && lerna bootstrap && jlpm lint && jlpm clean && jlpm build",
-    "build": "jlpm build:schema && jlpm build:completion-theme && jlpm build:theme-material && jlpm build:theme-vscode && jlpm build:meta && jlpm build:ws",
+    "build": "jlpm build:schema && jlpm build:completion-theme && jlpm build:theme-material && jlpm build:theme-vscode && jlpm build:meta && jlpm build:ws && jlpm build:jump",
     "build:schema": "lerna run build:schema --stream",
     "build:meta": "lerna run build --stream --scope @krassowski/jupyterlab-lsp-metapackage",
     "build:completion-theme": "lerna run build --stream --scope @krassowski/completion-theme",
     "build:theme-vscode": "lerna run build --stream --scope @krassowski/theme-vscode",
     "build:theme-material": "lerna run build --stream --scope @krassowski/theme-material",
     "build:ws": "lerna run build --stream --scope lsp-ws-connection",
+    "build:jump": "lerna run build --stream --scope @krassowski/jupyterlab_go_to_definition",
     "watch": "lerna run --parallel watch",
     "bundle": "lerna run --parallel bundle",
     "clean": "lerna run --parallel clean",

packages/jupyterlab-lsp/src/features/jump_to.ts

@@ -31,7 +31,7 @@ export const jumpToIcon = new LabIcon({
   svgstr: jumpToSvg
 });
 
-const FEATURE_ID = PLUGIN_ID + ':jump-to';
+const FEATURE_ID = PLUGIN_ID + ':jump_to';
 
 export class CMJumpToDefinition extends CodeMirrorIntegration {
   get jumper() {
@@ -59,7 +59,7 @@ export class CMJumpToDefinition extends CodeMirrorIntegration {
         const { button } = event;
         if (
           button === 0 &&
-          getModifierState(event, this.modifierKey as string)
+          getModifierState(event, this.modifierKey)
         ) {
           this.connection
             .getDefinition(virtual_position, document.document_info, false)
@@ -126,7 +126,6 @@ export class CMJumpToDefinition extends CodeMirrorIntegration {
 
     if (uris_equal(uri, document_uri)) {
       let editor_index = this.adapter.get_editor_index_at(virtual_position);
-      console.log('Editor index: ', editor_index);
       // if in current file, transform from the position within virtual document to the editor position:
       let editor_position = this.virtual_editor.transform_virtual_to_editor(
         virtual_position
@@ -136,8 +135,6 @@ export class CMJumpToDefinition extends CodeMirrorIntegration {
       console.log('Jump target within editor:', editor_position_ce);
 
       let contents_path = this.adapter.widget.context.path;
-      console.log('path', this.adapter.widget.context.path);
-      console.log('localPath', this.adapter.widget.context.localPath);
 
       this.jumper.global_jump({
         line: editor_position_ce.line,